Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(303)

Issue 2387033003: Make cols/rows/span not accept zero when set from idl (Closed)

Created:
4 years, 2 months ago by rwlbuis
Modified:
4 years, 2 months ago
Reviewers:
tkent
CC:
blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make cols/rows/span not accept zero when set from idl Make cols/rows/span not accept zero when set from idl, but do similar to what happens when setting the attribute, i.e. set the default values instead [1]. BUG=490511 [1] https://html.spec.whatwg.org/multipage/forms.html#attr-textarea-cols https://html.spec.whatwg.org/multipage/forms.html#attr-textarea-rows https://html.spec.whatwg.org/multipage/tables.html#dom-colgroup-span Committed: https://crrev.com/bd23011108522aacf45a19bc7f792abf2eece78d Cr-Commit-Position: refs/heads/master@{#422669}

Patch Set 1 #

Patch Set 2 : V2 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M third_party/WebKit/LayoutTests/imported/wpt/html/dom/reflection-forms-expected.txt View 1 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/imported/wpt/html/dom/reflection-tabular-expected.txt View 1 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLTableColElement.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLTextAreaElement.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
rwlbuis
PTAL.
4 years, 2 months ago (2016-10-03 21:41:40 UTC) #6
tkent
lgtm
4 years, 2 months ago (2016-10-03 23:31:26 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2387033003/20001
4 years, 2 months ago (2016-10-03 23:35:32 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-04 02:06:58 UTC) #11
commit-bot: I haz the power
4 years, 2 months ago (2016-10-04 02:09:04 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/bd23011108522aacf45a19bc7f792abf2eece78d
Cr-Commit-Position: refs/heads/master@{#422669}

Powered by Google App Engine
This is Rietveld 408576698