third_party/WebKit/Source/core/html/HTMLTableColElement.cpp - Issue 2387033003: Make cols/rows/span not accept zero when set from idl

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/core/html/HTMLTableColElement.cpp

Issue 2387033003: Make cols/rows/span not accept zero when set from idl (Closed)

Patch Set: V2 Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/imported/wpt/html/dom/reflection-tabular-expected.txt ('k') | third_party/WebKit/Source/core/html/HTMLTextAreaElement.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 1997 Martin Jones (mjones@kde.org)	2 * Copyright (C) 1997 Martin Jones (mjones@kde.org)

3 * (C) 1997 Torben Weis (weis@kde.org)	3 * (C) 1997 Torben Weis (weis@kde.org)

4 * (C) 1998 Waldo Bastian (bastian@kde.org)	4 * (C) 1998 Waldo Bastian (bastian@kde.org)

5 * (C) 1999 Lars Knoll (knoll@kde.org)	5 * (C) 1999 Lars Knoll (knoll@kde.org)

6 * (C) 1999 Antti Koivisto (koivisto@kde.org)	6 * (C) 1999 Antti Koivisto (koivisto@kde.org)

7 * Copyright (C) 2003, 2004, 2005, 2006, 2010 Apple Inc. All rights reserved.	7 * Copyright (C) 2003, 2004, 2005, 2006, 2010 Apple Inc. All rights reserved.

8 *	8 *

9 * This library is free software; you can redistribute it and/or	9 * This library is free software; you can redistribute it and/or

10 * modify it under the terms of the GNU Library General Public	10 * modify it under the terms of the GNU Library General Public

(...skipping 79 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
90 const StylePropertySet*	90 const StylePropertySet*

91 HTMLTableColElement::additionalPresentationAttributeStyle() {	91 HTMLTableColElement::additionalPresentationAttributeStyle() {

92 if (!hasTagName(colgroupTag))	92 if (!hasTagName(colgroupTag))

93 return nullptr;	93 return nullptr;

94 if (HTMLTableElement* table = findParentTable())	94 if (HTMLTableElement* table = findParentTable())

95 return table->additionalGroupStyle(false);	95 return table->additionalGroupStyle(false);

96 return nullptr;	96 return nullptr;

97 }	97 }

98	98

99 void HTMLTableColElement::setSpan(unsigned n) {	99 void HTMLTableColElement::setSpan(unsigned n) {

100 setUnsignedIntegralAttribute(spanAttr, n);	100 setUnsignedIntegralAttribute(spanAttr, n ? n : 1);

101 }	101 }

102	102

103 const AtomicString& HTMLTableColElement::width() const {	103 const AtomicString& HTMLTableColElement::width() const {

104 return getAttribute(widthAttr);	104 return getAttribute(widthAttr);

105 }	105 }

106	106

107 } // namespace blink	107 } // namespace blink

OLD	NEW