Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(330)

Unified Diff: third_party/WebKit/Source/core/html/HTMLTextAreaElement.cpp

Issue 2387033003: Make cols/rows/span not accept zero when set from idl (Closed)
Patch Set: V2 Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/html/HTMLTableColElement.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/html/HTMLTextAreaElement.cpp
diff --git a/third_party/WebKit/Source/core/html/HTMLTextAreaElement.cpp b/third_party/WebKit/Source/core/html/HTMLTextAreaElement.cpp
index 9dc31957b8291babe5059ad319c71c9bc1385618..e0094599748743d3198ce7e963cb7a80e2c1c627 100644
--- a/third_party/WebKit/Source/core/html/HTMLTextAreaElement.cpp
+++ b/third_party/WebKit/Source/core/html/HTMLTextAreaElement.cpp
@@ -626,11 +626,11 @@ void HTMLTextAreaElement::accessKeyAction(bool) {
}
void HTMLTextAreaElement::setCols(unsigned cols) {
- setUnsignedIntegralAttribute(colsAttr, cols);
+ setUnsignedIntegralAttribute(colsAttr, cols ? cols : defaultCols);
}
void HTMLTextAreaElement::setRows(unsigned rows) {
- setUnsignedIntegralAttribute(rowsAttr, rows);
+ setUnsignedIntegralAttribute(rowsAttr, rows ? rows : defaultRows);
}
bool HTMLTextAreaElement::matchesReadOnlyPseudoClass() const {
« no previous file with comments | « third_party/WebKit/Source/core/html/HTMLTableColElement.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698