third_party/WebKit/Source/core/html/HTMLTableColElement.cpp - Issue 2387033003: Make cols/rows/span not accept zero when set from idl

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLTableColElement.cpp

Issue 2387033003: Make cols/rows/span not accept zero when set from idl (Closed)

Patch Set: V2 Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/html/HTMLTableColElement.cpp

diff --git a/third_party/WebKit/Source/core/html/HTMLTableColElement.cpp b/third_party/WebKit/Source/core/html/HTMLTableColElement.cpp

index fc6ef7d788dc1494434273517f11e3eecb3fa3df..424c2ee76b7c62ea6f9c4221fa5f452d62ea20ad 100644

--- a/third_party/WebKit/Source/core/html/HTMLTableColElement.cpp

+++ b/third_party/WebKit/Source/core/html/HTMLTableColElement.cpp

@@ -97,7 +97,7 @@ HTMLTableColElement::additionalPresentationAttributeStyle() {

}

void HTMLTableColElement::setSpan(unsigned n) {

- setUnsignedIntegralAttribute(spanAttr, n);

+ setUnsignedIntegralAttribute(spanAttr, n ? n : 1);

}

const AtomicString& HTMLTableColElement::width() const {