[GeometryInterface] remove scaleNonUniform* method.

[GeometryInterface] remove scaleNonUniform* method.

parameter of scale* method was modified according to spec.
scaleNonUniform* method do not need any more.

spec list:
https://drafts.fxtf.org/geometry/#dom-dommatrixreadonly-scale
https://drafts.fxtf.org/geometry/#dom-dommatrix-scaleself

BUG=388780, 645887
Committed: https://crrev.com/89064304d942709fa79a51b51e540317f4bb7d9b
Cr-Commit-Position: refs/heads/master@{#425588}

[Hwanseung Lee, 2016-10-03 09:33:45]

Description was changed from

==========
[GeometryInterface] remove scaleNonUniform* method.

parameter of scale* method was modified according to spec.
and than scaleNonUniform* method do not need any more.

spec list:
https://drafts.fxtf.org/geometry/#dom-dommatrixreadonly-scale
https://drafts.fxtf.org/geometry/#dom-dommatrix-scaleself

BUG=388780, 645887
==========

to

==========
[GeometryInterface] remove scaleNonUniform* method.

parameter of scale* method was modified according to spec.
scaleNonUniform* method do not need any more.

spec list:
https://drafts.fxtf.org/geometry/#dom-dommatrixreadonly-scale
https://drafts.fxtf.org/geometry/#dom-dommatrix-scaleself

BUG=388780, 645887
==========

[Hwanseung Lee, 2016-10-03 09:39:13]

hs1217.lee@samsung.com changed reviewers:
+ dominicc@chromium.org, jinho.bang@samsung.com

[Hwanseung Lee, 2016-10-03 09:39:13]

@dominicc, zino
PTAL, thank you.

[zino, 2016-10-04 14:24:09]

https://codereview.chromium.org/2387003002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/dom/DOMMatrix.cpp (right):

https://codereview.chromium.org/2387003002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/dom/DOMMatrix.cpp:135: return
scaleNonUniformSelf(sx, sy, sz, ox, oy, oz);
Why did you leave this sacleNonUniformSelf function in C++ side.?

[Hwanseung Lee, 2016-10-04 22:21:53]

https://codereview.chromium.org/2387003002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/dom/DOMMatrix.cpp (right):

https://codereview.chromium.org/2387003002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/dom/DOMMatrix.cpp:135: return
scaleNonUniformSelf(sx, sy, sz, ox, oy, oz);
On 2016/10/04 14:24:09, zino wrote:
> Why did you leave this sacleNonUniformSelf function in C++ side.?

scale*, scale3d* method can use scaleNonUniformSelf without implement.
so scaleNonUniformSelf was moved as private instead of remove.
but newly scale* has same parameter with sacleNonUniformSelf.
on second thoughts, sacleNonUniformSelf do not need.
so i did remove scaleNonUniformSelf and upload new patchset.

[dominicc (has gone to gerrit), 2016-10-05 04:14:22]

The CQ bit was checked by dominicc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-05 04:14:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dominicc (has gone to gerrit), 2016-10-05 04:23:50]

Some feedback inline.

Could you write up a plan to upstream these tests to
https://github.com/w3c/web-platform-tests/ and send a note to blink-dev with the
plan? Just sketch how much work is left, what directory in web-platform-tests
you'll put them in, etc. Thanks!

https://codereview.chromium.org/2387003002/diff/60001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/fast/dom/geometry-interfaces-dom-matrix-scale.html
(right):

https://codereview.chromium.org/2387003002/diff/60001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/dom/geometry-interfaces-dom-matrix-scale.html:82:
var result = matrix.scaleSelf(3, 3);
This would be a more discerning test if you used a different value for sy,
especially since sy has special handling and may take the value of sx.

Same for 'scale(3, 3)' above.

https://codereview.chromium.org/2387003002/diff/60001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/dom/geometry-interfaces-dom-matrix-scale.html:109:
}, "DOMMatrix.scaleSelf(1, 1, 1, ox, oy, oz)");
Could you write a phase explaining what this test is about? It looks like you're
testing that uniform scale is the identity transform even with a different
origin.

[zino, 2016-10-05 04:25:07]

On 2016/10/05 04:23:50, dominicc wrote:
> Some feedback inline.
> 
> Could you write up a plan to upstream these tests to
> https://github.com/w3c/web-platform-tests/ and send a note to blink-dev with
the
> plan? Just sketch how much work is left, what directory in web-platform-tests
> you'll put them in, etc. Thanks!
> 

I have a plan to send the tests to web-platform-tests.

[zino, 2016-10-05 04:27:19]

On 2016/10/05 04:25:07, zino wrote:
> On 2016/10/05 04:23:50, dominicc wrote:
> > Some feedback inline.
> > 
> > Could you write up a plan to upstream these tests to
> > https://github.com/w3c/web-platform-tests/ and send a note to blink-dev with
> the
> > plan? Just sketch how much work is left, what directory in
web-platform-tests
> > you'll put them in, etc. Thanks!
> > 
> 
> I have a plan to send the tests to web-platform-tests.

If we are done this work once, we will upload these tests to web-platform-tests.
Currently, I think we need a small clean-up for exisiting tests.

[commit-bot: I haz the power, 2016-10-05 05:20:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-05 05:20:16]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Hwanseung Lee, 2016-10-06 14:19:13]

@dominicc

PTAL. could you review again?
i did add tests taking sx, sy(different with sx).
and add comment for scaleSelf(1, 1, 1, ox, oy, oz) test.
and also remove scaleNonUniformSelf at global-interface-listing-expected.txt.

https://codereview.chromium.org/2387003002/diff/60001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/fast/dom/geometry-interfaces-dom-matrix-scale.html
(right):

https://codereview.chromium.org/2387003002/diff/60001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/dom/geometry-interfaces-dom-matrix-scale.html:82:
var result = matrix.scaleSelf(3, 3);
On 2016/10/05 04:23:50, dominicc wrote:
> This would be a more discerning test if you used a different value for sy,
> especially since sy has special handling and may take the value of sx.
> 
> Same for 'scale(3, 3)' above.

Done.

https://codereview.chromium.org/2387003002/diff/60001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/dom/geometry-interfaces-dom-matrix-scale.html:109:
}, "DOMMatrix.scaleSelf(1, 1, 1, ox, oy, oz)");
On 2016/10/05 04:23:50, dominicc wrote:
> Could you write a phase explaining what this test is about? It looks like
you're
> testing that uniform scale is the identity transform even with a different
> origin.

Done.

[dominicc (has gone to gerrit), 2016-10-14 08:16:00]

Very close, sorry for the slow feedback. Just one more thing, maybe instead of

var x = y.fooSelf(...);
assert_something(x);
assert_something(y);

you could test more in the same lines of code by doing

var x = y.fooSelf(...);
assert_something(x);
assert_equal(x, y, 'x and y should be the exact same object');

I think assert_equal does ===, but if not, you want to assert that x and y are
===. Check how assert_equal is implemented in testharness.js to be sure!

https://codereview.chromium.org/2387003002/diff/120001/third_party/WebKit/Lay...
File
third_party/WebKit/LayoutTests/fast/dom/geometry-interfaces-dom-matrix-scale.html
(right):

https://codereview.chromium.org/2387003002/diff/120001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/fast/dom/geometry-interfaces-dom-matrix-scale.html:12:
assert_identity_2d_matrix(matrix);
Since matrix and result have the same value, maybe also test result !== matrix?

I assume we plan to upstream these tests to W3C so having something like that
isn't totally crazy, even though it is unlikely the Blink implementation is
buggy in that way.

https://codereview.chromium.org/2387003002/diff/120001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/fast/dom/geometry-interfaces-dom-matrix-scale.html:76:
assert_identity_2d_matrix(matrix);
With the *Self methods it's enough to test that result has the values you want
(identity matrix) and result === matrix; then you don't need to test the values
of matrix. Same situation below too.

[Hwanseung Lee, 2016-10-15 01:16:43]

@dominicc

your thoughts is correct.
assert_equal dose === using sameValue function().
(https://cs.chromium.org/chromium/src/third_party/WebKit/LayoutTests/resources...)

please review again. thank you.

https://codereview.chromium.org/2387003002/diff/120001/third_party/WebKit/Lay...
File
third_party/WebKit/LayoutTests/fast/dom/geometry-interfaces-dom-matrix-scale.html
(right):

https://codereview.chromium.org/2387003002/diff/120001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/fast/dom/geometry-interfaces-dom-matrix-scale.html:12:
assert_identity_2d_matrix(matrix);
On 2016/10/14 08:16:00, dominicc wrote:
> Since matrix and result have the same value, maybe also test result !==
matrix?
> 
> I assume we plan to upstream these tests to W3C so having something like that
> isn't totally crazy, even though it is unlikely the Blink implementation is
> buggy in that way.

Done.

https://codereview.chromium.org/2387003002/diff/120001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/fast/dom/geometry-interfaces-dom-matrix-scale.html:76:
assert_identity_2d_matrix(matrix);
On 2016/10/14 08:15:59, dominicc wrote:
> With the *Self methods it's enough to test that result has the values you want
> (identity matrix) and result === matrix; then you don't need to test the
values
> of matrix. Same situation below too.

Done.

[dominicc (has gone to gerrit), 2016-10-16 08:48:36]

lgtm

LGTM modulo one nit inline.

https://codereview.chromium.org/2387003002/diff/140001/third_party/WebKit/Lay...
File
third_party/WebKit/LayoutTests/fast/dom/geometry-interfaces-dom-matrix-scale.html
(right):

https://codereview.chromium.org/2387003002/diff/140001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/fast/dom/geometry-interfaces-dom-matrix-scale.html:13:
assert_not_equals(result, matrix, 'result and matrix should be diffrent
object');
Spelling: different

[Hwanseung Lee, 2016-10-16 08:54:59]

On 2016/10/16 08:48:36, dominicc wrote:
> lgtm
> 
> LGTM modulo one nit inline.
> 
>
https://codereview.chromium.org/2387003002/diff/140001/third_party/WebKit/Lay...
> File
>
third_party/WebKit/LayoutTests/fast/dom/geometry-interfaces-dom-matrix-scale.html
> (right):
> 
>
https://codereview.chromium.org/2387003002/diff/140001/third_party/WebKit/Lay...
>
third_party/WebKit/LayoutTests/fast/dom/geometry-interfaces-dom-matrix-scale.html:13:
> assert_not_equals(result, matrix, 'result and matrix should be diffrent
> object');
> Spelling: different

i did fix a typo. thank you.

[Hwanseung Lee, 2016-10-16 08:55:07]

The CQ bit was checked by hs1217.lee@samsung.com

[Hwanseung Lee, 2016-10-16 08:55:08]

The patchset sent to the CQ was uploaded after l-g-t-m from
dominicc@chromium.org
Link to the patchset: https://codereview.chromium.org/2387003002/#ps160001
(title: "fix a typo.")

[commit-bot: I haz the power, 2016-10-16 08:55:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-16 11:16:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-16 11:16:32]

Exceeded global retry quota

[Hwanseung Lee, 2016-10-16 11:17:25]

The CQ bit was checked by hs1217.lee@samsung.com

[commit-bot: I haz the power, 2016-10-16 11:17:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-16 11:21:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-16 11:21:42]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Hwanseung Lee, 2016-10-16 11:24:49]

The CQ bit was checked by hs1217.lee@samsung.com

[commit-bot: I haz the power, 2016-10-16 11:24:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-16 11:32:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-16 11:32:29]

Exceeded global retry quota

[Hwanseung Lee, 2016-10-16 11:38:47]

The CQ bit was checked by hs1217.lee@samsung.com

[Hwanseung Lee, 2016-10-16 11:38:47]

The patchset sent to the CQ was uploaded after l-g-t-m from
dominicc@chromium.org
Link to the patchset: https://codereview.chromium.org/2387003002/#ps200001
(title: "rebase origin")

[commit-bot: I haz the power, 2016-10-16 11:38:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-16 12:56:08]

Description was changed from

==========
[GeometryInterface] remove scaleNonUniform* method.

parameter of scale* method was modified according to spec.
scaleNonUniform* method do not need any more.

spec list:
https://drafts.fxtf.org/geometry/#dom-dommatrixreadonly-scale
https://drafts.fxtf.org/geometry/#dom-dommatrix-scaleself

BUG=388780, 645887
==========

to

==========
[GeometryInterface] remove scaleNonUniform* method.

parameter of scale* method was modified according to spec.
scaleNonUniform* method do not need any more.

spec list:
https://drafts.fxtf.org/geometry/#dom-dommatrixreadonly-scale
https://drafts.fxtf.org/geometry/#dom-dommatrix-scaleself

BUG=388780, 645887
==========

[commit-bot: I haz the power, 2016-10-16 12:56:09]

Committed patchset #11 (id:200001)

[commit-bot: I haz the power, 2016-10-16 12:58:19]

Description was changed from

==========
[GeometryInterface] remove scaleNonUniform* method.

parameter of scale* method was modified according to spec.
scaleNonUniform* method do not need any more.

spec list:
https://drafts.fxtf.org/geometry/#dom-dommatrixreadonly-scale
https://drafts.fxtf.org/geometry/#dom-dommatrix-scaleself

BUG=388780, 645887
==========

to

==========
[GeometryInterface] remove scaleNonUniform* method.

parameter of scale* method was modified according to spec.
scaleNonUniform* method do not need any more.

spec list:
https://drafts.fxtf.org/geometry/#dom-dommatrixreadonly-scale
https://drafts.fxtf.org/geometry/#dom-dommatrix-scaleself

BUG=388780, 645887

Committed: https://crrev.com/89064304d942709fa79a51b51e540317f4bb7d9b
Cr-Commit-Position: refs/heads/master@{#425588}
==========

[commit-bot: I haz the power, 2016-10-16 12:58:21]

Patchset 11 (id:??) landed as
https://crrev.com/89064304d942709fa79a51b51e540317f4bb7d9b
Cr-Commit-Position: refs/heads/master@{#425588}