[Extensions] Remove ExtensionFunction::SetError()

[Extensions] Remove ExtensionFunction::SetError()

An extension function error should be set only through the use of the
response (i.e., ExtensionFunction::Error()), and setting it directly
can lead to confusion and incorrect results. Remove
ExtensionFunction::SetError(). Other subclasses (like
AsyncExtensionFunction) still have accessors, but will be updated as
they are converted.

Also disable two more input IME API tests that were always failing, but
silently passed because of passing success despite having an error.

BUG=648275
Committed: https://crrev.com/fd7bb627894ab5fc1415c90f579dba779fddc70f
Cr-Commit-Position: refs/heads/master@{#422589}

[Devlin, 2016-10-01 04:42:58]

The CQ bit was checked by rdevlin.cronin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-01 04:43:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-01 05:40:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-01 05:40:46]

Dry run: Exceeded global retry quota

[Devlin, 2016-10-03 16:44:28]

The CQ bit was checked by rdevlin.cronin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-03 16:44:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-03 17:37:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-03 17:37:06]

Dry run: This issue passed the CQ dry run.

[Devlin, 2016-10-03 18:50:07]

Description was changed from

==========
Isolate
BUG=
==========

to

==========
[Extensions] Remove ExtensionFunction::SetError()

An extension function error should be set only through the use of the
response (i.e., ExtensionFunction::Error()), and setting it directly
can lead to confusion and incorrect results. Remove
ExtensionFunction::SetError(). Other subclasses (like
AsyncExtensionFunction) still have accessors, but will be updated as
they are converted.

Also disable two more input IME API tests that were always failing, but
silently passed because of passing success despite having an error.

BUG=648275
==========

[Devlin, 2016-10-03 18:50:19]

rdevlin.cronin@chromium.org changed reviewers:
+ lazyboy@chromium.org

[lazyboy, 2016-10-03 20:34:01]

lgtm with one nit.

https://codereview.chromium.org/2386823002/diff/20001/chrome/browser/extensio...
File chrome/browser/extensions/chrome_extension_function.h (right):

https://codereview.chromium.org/2386823002/diff/20001/chrome/browser/extensio...
chrome/browser/extensions/chrome_extension_function.h:59: void SetError(const
std::string& error);
nit: move this out of "ExtensionFunction:" group since it's not overriding
ExtensionFunction anymore.

https://codereview.chromium.org/2386823002/diff/20001/extensions/browser/exte...
File extensions/browser/extension_function.h (right):

https://codereview.chromium.org/2386823002/diff/20001/extensions/browser/exte...
extensions/browser/extension_function.h:636: void SetError(const std::string&
error);
Same here.

[Devlin, 2016-10-03 20:58:02]

The CQ bit was checked by rdevlin.cronin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-03 20:58:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-03 23:05:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-03 23:05:50]

Dry run: This issue passed the CQ dry run.

[Devlin, 2016-10-03 23:07:51]

https://codereview.chromium.org/2386823002/diff/20001/chrome/browser/extensio...
File chrome/browser/extensions/chrome_extension_function.h (right):

https://codereview.chromium.org/2386823002/diff/20001/chrome/browser/extensio...
chrome/browser/extensions/chrome_extension_function.h:59: void SetError(const
std::string& error);
On 2016/10/03 20:34:01, lazyboy wrote:
> nit: move this out of "ExtensionFunction:" group since it's not overriding
> ExtensionFunction anymore.

Good call, done.

https://codereview.chromium.org/2386823002/diff/20001/extensions/browser/exte...
File extensions/browser/extension_function.h (right):

https://codereview.chromium.org/2386823002/diff/20001/extensions/browser/exte...
extensions/browser/extension_function.h:636: void SetError(const std::string&
error);
On 2016/10/03 20:34:01, lazyboy wrote:
> Same here.

Done.

[Devlin, 2016-10-03 23:07:56]

The CQ bit was checked by rdevlin.cronin@chromium.org

[Devlin, 2016-10-03 23:07:56]

The patchset sent to the CQ was uploaded after l-g-t-m from lazyboy@chromium.org
Link to the patchset: https://codereview.chromium.org/2386823002/#ps40001
(title: "lazyboy's")

[commit-bot: I haz the power, 2016-10-03 23:08:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-03 23:15:06]

Description was changed from

==========
[Extensions] Remove ExtensionFunction::SetError()

An extension function error should be set only through the use of the
response (i.e., ExtensionFunction::Error()), and setting it directly
can lead to confusion and incorrect results. Remove
ExtensionFunction::SetError(). Other subclasses (like
AsyncExtensionFunction) still have accessors, but will be updated as
they are converted.

Also disable two more input IME API tests that were always failing, but
silently passed because of passing success despite having an error.

BUG=648275
==========

to

==========
[Extensions] Remove ExtensionFunction::SetError()

An extension function error should be set only through the use of the
response (i.e., ExtensionFunction::Error()), and setting it directly
can lead to confusion and incorrect results. Remove
ExtensionFunction::SetError(). Other subclasses (like
AsyncExtensionFunction) still have accessors, but will be updated as
they are converted.

Also disable two more input IME API tests that were always failing, but
silently passed because of passing success despite having an error.

BUG=648275
==========

[commit-bot: I haz the power, 2016-10-03 23:15:07]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-10-03 23:17:05]

Description was changed from

==========
[Extensions] Remove ExtensionFunction::SetError()

An extension function error should be set only through the use of the
response (i.e., ExtensionFunction::Error()), and setting it directly
can lead to confusion and incorrect results. Remove
ExtensionFunction::SetError(). Other subclasses (like
AsyncExtensionFunction) still have accessors, but will be updated as
they are converted.

Also disable two more input IME API tests that were always failing, but
silently passed because of passing success despite having an error.

BUG=648275
==========

to

==========
[Extensions] Remove ExtensionFunction::SetError()

An extension function error should be set only through the use of the
response (i.e., ExtensionFunction::Error()), and setting it directly
can lead to confusion and incorrect results. Remove
ExtensionFunction::SetError(). Other subclasses (like
AsyncExtensionFunction) still have accessors, but will be updated as
they are converted.

Also disable two more input IME API tests that were always failing, but
silently passed because of passing success despite having an error.

BUG=648275

Committed: https://crrev.com/fd7bb627894ab5fc1415c90f579dba779fddc70f
Cr-Commit-Position: refs/heads/master@{#422589}
==========

[commit-bot: I haz the power, 2016-10-03 23:17:06]

Patchset 3 (id:??) landed as
https://crrev.com/fd7bb627894ab5fc1415c90f579dba779fddc70f
Cr-Commit-Position: refs/heads/master@{#422589}