[Extensions] Remove ExtensionFunction::SetError()

chrome/browser/extensions/chrome_extension_function.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_EXTENSIONS_CHROME_EXTENSION_FUNCTION_H_
 #define CHROME_BROWSER_EXTENSIONS_CHROME_EXTENSION_FUNCTION_H_
 
 #include "chrome/browser/extensions/chrome_extension_function_details.h"
 #include "extensions/browser/extension_function.h"
 
@@ skipping 38 matching lines @@
   // shutdown when there are no active windows.
   //
   // TODO(stevenjb): Replace this with GetExtensionWindowController().
   Browser* GetCurrentBrowser();
 
   // Same as above but uses WindowControllerList instead of BrowserList.
   extensions::WindowController* GetExtensionWindowController();
 
   // ExtensionFunction:
   content::WebContents* GetAssociatedWebContents() override;
-  void SetError(const std::string& error) override;
+  void SetError(const std::string& error);

[lazyboy, 2016/10/03 20:34:01]

nit: move this out of "ExtensionFunction:" group since it's not overriding
ExtensionFunction anymore.

[Devlin, 2016/10/03 23:07:50]

Good call, done.

   const std::string& GetError() const override;
 
  protected:
   ~ChromeUIThreadExtensionFunction() override;
 
   // Responds with success/failure. |results_| or |error_| should be set
   // accordingly.
   void SendResponse(bool success);
 
   // Sets a single Value as the results of the function.
@@ skipping 62 matching lines @@
   static bool ValidationFailure(ChromeSyncExtensionFunction* function);
 
  private:
   // If you're hitting a compile error here due to "final" - great! You're doing
   // the right thing, you just need to extend ChromeUIThreadExtensionFunction
   // instead of ChromeSyncExtensionFunction.
   ResponseAction Run() final;
 };
 
 #endif  // CHROME_BROWSER_EXTENSIONS_CHROME_EXTENSION_FUNCTION_H_