Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2798)

Unified Diff: chrome/browser/extensions/api/autofill_private/autofill_private_api.cc

Issue 2386823002: [Extensions] Remove ExtensionFunction::SetError() (Closed)
Patch Set: lazyboy's Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/extensions/api/input_ime/input_ime_api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/api/autofill_private/autofill_private_api.cc
diff --git a/chrome/browser/extensions/api/autofill_private/autofill_private_api.cc b/chrome/browser/extensions/api/autofill_private/autofill_private_api.cc
index 91430bc95a460930fc057a82f99086afdc0d2e0e..6adbbac3568e1fbf883a9ed3e219a2887868cb11 100644
--- a/chrome/browser/extensions/api/autofill_private/autofill_private_api.cc
+++ b/chrome/browser/extensions/api/autofill_private/autofill_private_api.cc
@@ -178,10 +178,8 @@ ExtensionFunction::ResponseAction AutofillPrivateSaveAddressFunction::Run() {
autofill::PersonalDataManager* personal_data =
autofill::PersonalDataManagerFactory::GetForProfile(
chrome_details_.GetProfile());
- if (!personal_data || !personal_data->IsDataLoaded()) {
- SetError(kErrorDataUnavailable);
- return RespondNow(NoArguments());
- }
+ if (!personal_data || !personal_data->IsDataLoaded())
+ return RespondNow(Error(kErrorDataUnavailable));
api::autofill_private::AddressEntry* address = &parameters->address;
@@ -367,10 +365,8 @@ ExtensionFunction::ResponseAction AutofillPrivateSaveCreditCardFunction::Run() {
autofill::PersonalDataManager* personal_data =
autofill::PersonalDataManagerFactory::GetForProfile(
chrome_details_.GetProfile());
- if (!personal_data || !personal_data->IsDataLoaded()) {
- SetError(kErrorDataUnavailable);
- return RespondNow(NoArguments());
- }
+ if (!personal_data || !personal_data->IsDataLoaded())
+ return RespondNow(Error(kErrorDataUnavailable));
api::autofill_private::CreditCardEntry* card = &parameters->card;
@@ -426,10 +422,8 @@ ExtensionFunction::ResponseAction AutofillPrivateRemoveEntryFunction::Run() {
autofill::PersonalDataManager* personal_data =
autofill::PersonalDataManagerFactory::GetForProfile(
chrome_details_.GetProfile());
- if (!personal_data || !personal_data->IsDataLoaded()) {
- SetError(kErrorDataUnavailable);
- return RespondNow(NoArguments());
- }
+ if (!personal_data || !personal_data->IsDataLoaded())
+ return RespondNow(Error(kErrorDataUnavailable));
personal_data->RemoveByGUID(parameters->guid);
@@ -478,10 +472,8 @@ ExtensionFunction::ResponseAction AutofillPrivateMaskCreditCardFunction::Run() {
autofill::PersonalDataManager* personal_data =
autofill::PersonalDataManagerFactory::GetForProfile(
chrome_details_.GetProfile());
- if (!personal_data || !personal_data->IsDataLoaded()) {
- SetError(kErrorDataUnavailable);
- return RespondNow(NoArguments());
- }
+ if (!personal_data || !personal_data->IsDataLoaded())
+ return RespondNow(Error(kErrorDataUnavailable));
personal_data->ResetFullServerCard(parameters->guid);
« no previous file with comments | « no previous file | chrome/browser/extensions/api/input_ime/input_ime_api.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698