Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(344)

Unified Diff: chrome/browser/extensions/api/tabs/windows_util.h

Issue 2386823002: [Extensions] Remove ExtensionFunction::SetError() (Closed)
Patch Set: lazyboy's Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/api/tabs/tabs_api.cc ('k') | chrome/browser/extensions/api/tabs/windows_util.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/api/tabs/windows_util.h
diff --git a/chrome/browser/extensions/api/tabs/windows_util.h b/chrome/browser/extensions/api/tabs/windows_util.h
index 940d380ebe4b2a82e5c2f2791546ba31efcfe9f7..b8b20c6f3619ec4d70530f9d75cfaace1961d4e3 100644
--- a/chrome/browser/extensions/api/tabs/windows_util.h
+++ b/chrome/browser/extensions/api/tabs/windows_util.h
@@ -21,11 +21,12 @@ class WindowController;
namespace windows_util {
// Populates |controller| for given |window_id|. If the window is not found,
-// returns false and sets UIThreadExtensionFunction error_.
+// returns false and sets |error|.
bool GetWindowFromWindowID(UIThreadExtensionFunction* function,
int window_id,
extensions::WindowController::TypeFilter filter,
- extensions::WindowController** controller);
+ extensions::WindowController** controller,
+ std::string* error);
// Returns true if |function| (and the profile and extension that it was
// invoked from) can operate on the window wrapped by |window_controller|.
« no previous file with comments | « chrome/browser/extensions/api/tabs/tabs_api.cc ('k') | chrome/browser/extensions/api/tabs/windows_util.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698