Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 2386473003: Fix issue with descendants of aria-activedescendant being marked as focusable. (Closed)

Created:
4 years, 2 months ago by dmazzoni
Modified:
4 years, 2 months ago
Reviewers:
aboxhall
CC:
chromium-reviews, aboxhall, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, haraken, nektarios, je_julie, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, blink-reviews, dmazzoni
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix issue with descendants of aria-activedescendant being marked as focusable. The ARIA spec says that descendants of a node with aria-activedescendant set should be marked as focusable if they have an ARIA role. But this doesn't make sense if the ARIA role is "none" or "presentation", so fix that. Also ensure that we recompute cached attributes whenever aria-activedescendant changes, even if it doesn't point to a valid ID, because it can affect focusability. BUG=651127 Committed: https://crrev.com/6940f7313fe70eb077836a6bdaa8502ffb256ad1 Cr-Commit-Position: refs/heads/master@{#422164}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
M third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXObjectCacheImpl.cpp View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
dmazzoni
4 years, 2 months ago (2016-09-30 16:50:03 UTC) #3
aboxhall
lgtm
4 years, 2 months ago (2016-09-30 17:04:13 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2386473003/1
4 years, 2 months ago (2016-09-30 18:40:49 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-30 18:48:18 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-09-30 18:52:26 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6940f7313fe70eb077836a6bdaa8502ffb256ad1
Cr-Commit-Position: refs/heads/master@{#422164}

Powered by Google App Engine
This is Rietveld 408576698