Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(819)

Unified Diff: third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp

Issue 2386473003: Fix issue with descendants of aria-activedescendant being marked as focusable. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/modules/accessibility/AXObjectCacheImpl.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp
diff --git a/third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp b/third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp
index 6c1c098d4741d97f4c7fa32b7370b8aac6914c10..379504be0b81b15b4f48ac4a0b992a8830e52770 100644
--- a/third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp
+++ b/third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp
@@ -1103,8 +1103,8 @@ bool AXNodeObject::canSetFocusAttribute() const
return true;
// Children of elements with an aria-activedescendant attribute should be
- // focusable if they have an ARIA role.
- if (ariaRoleAttribute() != UnknownRole && ancestorExposesActiveDescendant())
+ // focusable if they have a (non-presentational) ARIA role.
+ if (!isPresentational() && ariaRoleAttribute() != UnknownRole && ancestorExposesActiveDescendant())
return true;
// NOTE: It would be more accurate to ask the document whether setFocusedNode() would
« no previous file with comments | « no previous file | third_party/WebKit/Source/modules/accessibility/AXObjectCacheImpl.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698