Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(321)

Side by Side Diff: third_party/WebKit/Source/modules/accessibility/AXObjectCacheImpl.cpp

Issue 2386473003: Fix issue with descendants of aria-activedescendant being marked as focusable. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2014, Google Inc. All rights reserved. 2 * Copyright (C) 2014, Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 965 matching lines...) Expand 10 before | Expand all | Expand 10 after
976 976
977 postNotification(obj, AXCheckedStateChanged); 977 postNotification(obj, AXCheckedStateChanged);
978 978
979 AXObject* listbox = obj->parentObjectUnignored(); 979 AXObject* listbox = obj->parentObjectUnignored();
980 if (listbox && listbox->roleValue() == ListBoxRole) 980 if (listbox && listbox->roleValue() == ListBoxRole)
981 postNotification(listbox, AXSelectedChildrenChanged); 981 postNotification(listbox, AXSelectedChildrenChanged);
982 } 982 }
983 983
984 void AXObjectCacheImpl::handleActiveDescendantChanged(Node* node) 984 void AXObjectCacheImpl::handleActiveDescendantChanged(Node* node)
985 { 985 {
986 // Changing the active descendant should trigger recomputing all
987 // cached values even if it doesn't result in a notification, because
988 // it can affect what's focusable or not.
989 m_modificationCount++;
990
986 if (AXObject* obj = getOrCreate(node)) 991 if (AXObject* obj = getOrCreate(node))
987 obj->handleActiveDescendantChanged(); 992 obj->handleActiveDescendantChanged();
988 } 993 }
989 994
990 void AXObjectCacheImpl::handleAriaRoleChanged(Node* node) 995 void AXObjectCacheImpl::handleAriaRoleChanged(Node* node)
991 { 996 {
992 if (AXObject* obj = getOrCreate(node)) { 997 if (AXObject* obj = getOrCreate(node)) {
993 obj->updateAccessibilityRole(); 998 obj->updateAccessibilityRole();
994 m_modificationCount++; 999 m_modificationCount++;
995 obj->notifyIfIgnoredValueChanged(); 1000 obj->notifyIfIgnoredValueChanged();
(...skipping 288 matching lines...) Expand 10 before | Expand all | Expand 10 after
1284 visitor->trace(m_document); 1289 visitor->trace(m_document);
1285 visitor->trace(m_nodeObjectMapping); 1290 visitor->trace(m_nodeObjectMapping);
1286 1291
1287 visitor->trace(m_objects); 1292 visitor->trace(m_objects);
1288 visitor->trace(m_notificationsToPost); 1293 visitor->trace(m_notificationsToPost);
1289 1294
1290 AXObjectCache::trace(visitor); 1295 AXObjectCache::trace(visitor);
1291 } 1296 }
1292 1297
1293 } // namespace blink 1298 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698