Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(792)

Unified Diff: third_party/WebKit/Source/modules/accessibility/AXObjectCacheImpl.cpp

Issue 2386473003: Fix issue with descendants of aria-activedescendant being marked as focusable. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/modules/accessibility/AXObjectCacheImpl.cpp
diff --git a/third_party/WebKit/Source/modules/accessibility/AXObjectCacheImpl.cpp b/third_party/WebKit/Source/modules/accessibility/AXObjectCacheImpl.cpp
index 7df53a74a50a9c87e7d258b1f3cf56d67559efcf..0f97ca9e294a357df74503a3fa1787c44c0daa24 100644
--- a/third_party/WebKit/Source/modules/accessibility/AXObjectCacheImpl.cpp
+++ b/third_party/WebKit/Source/modules/accessibility/AXObjectCacheImpl.cpp
@@ -983,6 +983,11 @@ void AXObjectCacheImpl::handleAriaSelectedChanged(Node* node)
void AXObjectCacheImpl::handleActiveDescendantChanged(Node* node)
{
+ // Changing the active descendant should trigger recomputing all
+ // cached values even if it doesn't result in a notification, because
+ // it can affect what's focusable or not.
+ m_modificationCount++;
+
if (AXObject* obj = getOrCreate(node))
obj->handleActiveDescendantChanged();
}
« no previous file with comments | « third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698