Expose BaseAudioContext prototype

Expose BaseAudioContext prototype

Refactoring of BaseAudioContext (https://codereview.chromium.org/1865583002)
changed the prototype structure of AudioContext/OfflineAudioContext and
developers could not call hasOwnProperty() on BaseAudioContext because
it was not exposed to the JS domain.

This CL exposes BaseAudioContext's prototype. Also it adds 3 new layout
tests for each audio context and removes the old context property test.

BUG=555608, 661637
TEST=
LayoutTests/webaudio/baseaudiocontext-properties.html
LayoutTests/webaudio/audiocontext-properties.html
LayoutTests/webaudio/offlineaudiocontext-properties.html

Committed: https://crrev.com/5ec22676c144539f37f15740f4d712bb298ea02a
Cr-Commit-Position: refs/heads/master@{#431105}

[hongchan, 2016-10-03 19:59:53]

hongchan@chromium.org changed reviewers:
+ rtoy@chromium.org

[hongchan, 2016-10-03 19:59:54]

PTAL on new layout tests.

We still have no decision, but I would like to check-in code as soon as we have
one.

[Raymond Toy, 2016-10-03 20:19:20]

https://codereview.chromium.org/2386303002/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/webaudio/context-properties.html (left):

https://codereview.chromium.org/2386303002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/webaudio/context-properties.html:18:
shouldBeUndefined("onlineContext.oncomplete");
Haven't you reduced test coverage by deleting this test?  We don't test that an
AudioContext doesn't have oncomplete and startRendering.

https://codereview.chromium.org/2386303002/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/webaudio/resources/context-properties.js
(right):

https://codereview.chromium.org/2386303002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/webaudio/resources/context-properties.js:6:
'destination',
Should this be alphabetical? Or maybe alphabetical attributes followed by
alphabetical methods?

[hongchan, 2016-10-03 20:31:20]

https://codereview.chromium.org/2386303002/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/webaudio/context-properties.html (left):

https://codereview.chromium.org/2386303002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/webaudio/context-properties.html:18:
shouldBeUndefined("onlineContext.oncomplete");
On 2016/10/03 20:19:20, Raymond Toy wrote:
> Haven't you reduced test coverage by deleting this test?  We don't test that
an
> AudioContext doesn't have oncomplete and startRendering.

This boils down to another question: do we need to cross-check all the
properties against each other? For example, checking AC, OAC props against BAC?

https://codereview.chromium.org/2386303002/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/webaudio/resources/context-properties.js
(right):

https://codereview.chromium.org/2386303002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/webaudio/resources/context-properties.js:6:
'destination',
On 2016/10/03 20:19:20, Raymond Toy wrote:
> Should this be alphabetical? Or maybe alphabetical attributes followed by
> alphabetical methods?

This is the order from the enumeration by the 'in' operator. The alphabetical
order works for me.

[Raymond Toy, 2016-10-03 20:36:38]

https://codereview.chromium.org/2386303002/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/webaudio/context-properties.html (left):

https://codereview.chromium.org/2386303002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/webaudio/context-properties.html:18:
shouldBeUndefined("onlineContext.oncomplete");
On 2016/10/03 20:31:19, hoch wrote:
> On 2016/10/03 20:19:20, Raymond Toy wrote:
> > Haven't you reduced test coverage by deleting this test?  We don't test that
> an
> > AudioContext doesn't have oncomplete and startRendering.
> 
> This boils down to another question: do we need to cross-check all the
> properties against each other? For example, checking AC, OAC props against
BAC?

Don't actually know.  Probably should in the future, but I'm ok for now if we
just added one quick special test for AudioContext to check that these don't
exist. (So we don't lose coverage.)

[hongchan, 2016-11-02 22:00:17]

PTAL again.

I'll ask the review from tkent@ once we think this is good.

[Raymond Toy, 2016-11-02 22:10:09]

Looks good, except for a few minor details.

https://codereview.chromium.org/2386303002/diff/60001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/webaudio/audiocontext-properties.html
(right):

https://codereview.chromium.org/2386303002/diff/60001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/webaudio/audiocontext-properties.html:20:
targetDescription: 'AudioContext.prototype',
Can't you just print out targetPrototype name in the test so you don't have to
duplicate it with targetDescription?

https://codereview.chromium.org/2386303002/diff/60001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/webaudio/resources/context-properties.js
(right):

https://codereview.chromium.org/2386303002/diff/60001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/webaudio/resources/context-properties.js:35: //
'createConstantSource'
This should be available now.

Also, I think that it would be useful to have a check that BaseAudioContext
doesn't have properties not listed in BaseAudioContextOwnProperties (taking care
of the exceptions).

https://codereview.chromium.org/2386303002/diff/60001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/webaudio/resources/context-properties.js:58: //
TODO(hongchan): OAC's suspend is different from the BAC but the interface
"BAC"?

[hongchan, 2016-11-02 22:46:50]

https://codereview.chromium.org/2386303002/diff/60001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/webaudio/audiocontext-properties.html
(right):

https://codereview.chromium.org/2386303002/diff/60001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/webaudio/audiocontext-properties.html:20:
targetDescription: 'AudioContext.prototype',
On 2016/11/02 22:10:09, Raymond Toy wrote:
> Can't you just print out targetPrototype name in the test so you don't have to
> duplicate it with targetDescription?

How can I do that? Just curious. I am not sure how I can query the name (string)
of a prototype object. I can certainly do some string manipulation to extract
the name of the object, but I think that's over-engineering unless you want to
use somewhere else.

https://codereview.chromium.org/2386303002/diff/60001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/webaudio/resources/context-properties.js
(right):

https://codereview.chromium.org/2386303002/diff/60001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/webaudio/resources/context-properties.js:35: //
'createConstantSource'
On 2016/11/02 22:10:09, Raymond Toy wrote:
> This should be available now.
> 
> Also, I think that it would be useful to have a check that BaseAudioContext
> doesn't have properties not listed in BaseAudioContextOwnProperties (taking
care
> of the exceptions).

Done.

https://codereview.chromium.org/2386303002/diff/60001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/webaudio/resources/context-properties.js:58: //
TODO(hongchan): OAC's suspend is different from the BAC but the interface
On 2016/11/02 22:10:09, Raymond Toy wrote:
> "BAC"?

BaseAudioContext.

[Raymond Toy, 2016-11-02 23:01:07]

https://codereview.chromium.org/2386303002/diff/60001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/webaudio/audiocontext-properties.html
(right):

https://codereview.chromium.org/2386303002/diff/60001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/webaudio/audiocontext-properties.html:20:
targetDescription: 'AudioContext.prototype',
On 2016/11/02 22:46:50, hongchan wrote:
> On 2016/11/02 22:10:09, Raymond Toy wrote:
> > Can't you just print out targetPrototype name in the test so you don't have
to
> > duplicate it with targetDescription?
> 
> How can I do that? Just curious. I am not sure how I can query the name
(string)
> of a prototype object. I can certainly do some string manipulation to extract
> the name of the object, but I think that's over-engineering unless you want to
> use somewhere else. 

Maybe set targetPrototype to "AudioContext", and use
window[targetPrototype].prototype to get the prototype and use it for printing
the description. Of course, if you do this, rename targetPrototype to
targetContext or something.

https://codereview.chromium.org/2386303002/diff/60001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/webaudio/resources/context-properties.js
(right):

https://codereview.chromium.org/2386303002/diff/60001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/webaudio/resources/context-properties.js:58: //
TODO(hongchan): OAC's suspend is different from the BAC but the interface
On 2016/11/02 22:46:50, hongchan wrote:
> On 2016/11/02 22:10:09, Raymond Toy wrote:
> > "BAC"?
> 
> BaseAudioContext.

Let's not use abbreviations.

[hongchan, 2016-11-03 22:09:25]

PTAL. I rewrote the test so we can detect any change in the prototype
properties.

[Raymond Toy, 2016-11-03 22:37:15]

lgtm with nits.

Can you paste the actual output from the tests? That's fairly informative, and
it's really hard to know from reading the tests.

https://codereview.chromium.org/2386303002/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/modules/webaudio/OfflineAudioContext.idl (right):

https://codereview.chromium.org/2386303002/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/webaudio/OfflineAudioContext.idl:39: //
[CallWith=ScriptState, ImplementedAs=resumeContext,
MeasureAs=OfflineAudioContextResume] Promise<void> resume();
Did you mean to delete this?

[hongchan, 2016-11-03 22:41:52]

Here is the result from the test.

---
baseaudiocontext-properties.html

This is a testharness.js-based test.
PASS The property "constructor" was expected and found successfully. 
PASS The property "createAnalyser" was expected and found successfully. 
PASS The property "createBiquadFilter" was expected and found successfully. 
PASS The property "createBuffer" was expected and found successfully. 
PASS The property "createBufferSource" was expected and found successfully. 
PASS The property "createChannelMerger" was expected and found successfully. 
PASS The property "createChannelSplitter" was expected and found successfully. 
PASS The property "createConstantSource" was expected and found successfully. 
PASS The property "createConvolver" was expected and found successfully. 
PASS The property "createDelay" was expected and found successfully. 
PASS The property "createDynamicsCompressor" was expected and found
successfully. 
PASS The property "createGain" was expected and found successfully. 
PASS The property "createIIRFilter" was expected and found successfully. 
PASS The property "createOscillator" was expected and found successfully. 
PASS The property "createPanner" was expected and found successfully. 
PASS The property "createPeriodicWave" was expected and found successfully. 
PASS The property "createScriptProcessor" was expected and found successfully. 
PASS The property "createStereoPanner" was expected and found successfully. 
PASS The property "createWaveShaper" was expected and found successfully. 
PASS The property "currentTime" was expected and found successfully. 
PASS The property "decodeAudioData" was expected and found successfully. 
PASS The property "destination" was expected and found successfully. 
PASS The property "listener" was expected and found successfully. 
PASS The property "onstatechange" was expected and found successfully. 
PASS The property "resume" was expected and found successfully. 
PASS The property "sampleRate" was expected and found successfully. 
PASS The property "state" was expected and found successfully. 
PASS The property "createMediaElementSource" was expected and found
successfully. 
PASS The property "createMediaStreamDestination" was expected and found
successfully. 
PASS The property "createMediaStreamSource" was expected and found successfully.

Harness: the test ran to completion.
---

---
audiocontext-properties.html

This is a testharness.js-based test.
PASS The property "close" was expected and found successfully. 
PASS The property "constructor" was expected and found successfully. 
PASS The property "suspend" was expected and found successfully. 
Harness: the test ran to completion.
---

---
offlineaudiocontext-properties.html

This is a testharness.js-based test.
PASS The property "constructor" was expected and found successfully. 
PASS The property "length" was expected and found successfully. 
PASS The property "oncomplete" was expected and found successfully. 
PASS The property "startRendering" was expected and found successfully. 
PASS The property "suspend" was expected and found successfully. 
Harness: the test ran to completion.
---

https://codereview.chromium.org/2386303002/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/modules/webaudio/OfflineAudioContext.idl (right):

https://codereview.chromium.org/2386303002/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/webaudio/OfflineAudioContext.idl:39: //
[CallWith=ScriptState, ImplementedAs=resumeContext,
MeasureAs=OfflineAudioContextResume] Promise<void> resume();
On 2016/11/03 22:37:15, Raymond Toy wrote:
> Did you mean to delete this?

Oops.

[hongchan, 2016-11-03 22:43:23]

The CQ bit was checked by hongchan@chromium.org to run a CQ dry run

[hongchan, 2016-11-03 22:43:34]

Description was changed from

==========
Expose BaseAudioContext prototype

Refactoring of BaseAudioContext (https://codereview.chromium.org/1865583002)
changed the prototype structure of AudioContext/OfflineAudioContext and
developers could not call hasOwnProperty() on BaseAudioContext because
it was not exposed to the JS domain.

This CL exposes BaseAudioContext's prototype. Also it adds 3 new layout
tests for each audio context and removes the old context property test.

BUG=555608
TEST=
LayoutTests/webaudio/baseaudiocontext-properties.html
LayoutTests/webaudio/audiocontext-properties.html
LayoutTests/webaudio/offlineaudiocontext-properties.html
==========

to

==========
Expose BaseAudioContext prototype

Refactoring of BaseAudioContext (https://codereview.chromium.org/1865583002)
changed the prototype structure of AudioContext/OfflineAudioContext and
developers could not call hasOwnProperty() on BaseAudioContext because
it was not exposed to the JS domain.

This CL exposes BaseAudioContext's prototype. Also it adds 3 new layout
tests for each audio context and removes the old context property test.

BUG=555608
TEST=
LayoutTests/webaudio/baseaudiocontext-properties.html
LayoutTests/webaudio/audiocontext-properties.html
LayoutTests/webaudio/offlineaudiocontext-properties.html
==========

[hongchan, 2016-11-03 22:43:34]

hongchan@chromium.org changed reviewers:
+ tkent@chromium.org

[commit-bot: I haz the power, 2016-11-03 22:44:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[hongchan, 2016-11-03 22:48:09]

tkent@ 

PTAL at API changes.

I have not merge the fix to the spec yet, the WG decision on IDL change has been
made:
https://github.com/WebAudio/web-audio-api/issues/1060

To land this change soon is necessary, because we landed the BaseAudioContext
interface recently but forgot to expose itself to the main thread.

Please let me know if you think this change requires an intent/PSA/chrome status
update.

[tkent, 2016-11-04 00:33:10]

lgtm.
I don't think we need additional paper work.  I believe there are no risk this
time.

[commit-bot: I haz the power, 2016-11-04 00:36:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-04 00:37:00]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[hongchan, 2016-11-04 16:03:27]

The CQ bit was checked by hongchan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-04 16:04:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[hongchan, 2016-11-04 16:04:06]

Description was changed from

==========
Expose BaseAudioContext prototype

Refactoring of BaseAudioContext (https://codereview.chromium.org/1865583002)
changed the prototype structure of AudioContext/OfflineAudioContext and
developers could not call hasOwnProperty() on BaseAudioContext because
it was not exposed to the JS domain.

This CL exposes BaseAudioContext's prototype. Also it adds 3 new layout
tests for each audio context and removes the old context property test.

BUG=555608
TEST=
LayoutTests/webaudio/baseaudiocontext-properties.html
LayoutTests/webaudio/audiocontext-properties.html
LayoutTests/webaudio/offlineaudiocontext-properties.html
==========

to

==========
Expose BaseAudioContext prototype

Refactoring of BaseAudioContext (https://codereview.chromium.org/1865583002)
changed the prototype structure of AudioContext/OfflineAudioContext and
developers could not call hasOwnProperty() on BaseAudioContext because
it was not exposed to the JS domain.

This CL exposes BaseAudioContext's prototype. Also it adds 3 new layout
tests for each audio context and removes the old context property test.

BUG=555608, 661637
TEST=
LayoutTests/webaudio/baseaudiocontext-properties.html
LayoutTests/webaudio/audiocontext-properties.html
LayoutTests/webaudio/offlineaudiocontext-properties.html
==========

[commit-bot: I haz the power, 2016-11-04 18:18:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-04 18:18:45]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[hongchan, 2016-11-04 20:59:57]

The CQ bit was checked by hongchan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-04 21:00:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[hongchan, 2016-11-07 19:41:11]

Patchset #11 (id:200001) has been deleted

[hongchan, 2016-11-07 19:41:19]

Patchset #10 (id:180001) has been deleted

[hongchan, 2016-11-07 19:41:27]

Patchset #9 (id:160001) has been deleted

[hongchan, 2016-11-07 19:41:39]

The CQ bit was checked by hongchan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-07 19:42:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[hongchan, 2016-11-07 19:43:00]

hongchan@chromium.org changed reviewers:
+ rbyers@chromium.org

[hongchan, 2016-11-07 19:43:01]

rbyers@

PTAL - I keep getting a layout test failure from:
|virtual/stable/webexposed/global-interface-listing-expected.txt|

Do I need to do something special to pass this test?

[commit-bot: I haz the power, 2016-11-07 20:46:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-07 20:46:02]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[hongchan, 2016-11-07 21:41:23]

The CQ bit was checked by hongchan@chromium.org to run a CQ dry run

[hongchan, 2016-11-07 21:41:36]

Patchset #9 (id:220001) has been deleted

[commit-bot: I haz the power, 2016-11-07 21:41:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-08 00:10:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-08 00:10:04]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[tkent, 2016-11-08 01:25:59]

On 2016/11/07 at 19:43:01, hongchan wrote:
> rbyers@
> 
> PTAL - I keep getting a layout test failure from:
> |virtual/stable/webexposed/global-interface-listing-expected.txt|
> 
> Do I need to do something special to pass this test?

I think you need to update
LayoutTests/platform/*/virtual/stable/webexposed/global-interface-listing-expected.txt
too.

[hongchan, 2016-11-08 05:50:48]

On 2016/11/08 01:25:59, tkent wrote:
> On 2016/11/07 at 19:43:01, hongchan wrote:
> > rbyers@
> > 
> > PTAL - I keep getting a layout test failure from:
> > |virtual/stable/webexposed/global-interface-listing-expected.txt|
> > 
> > Do I need to do something special to pass this test?
> 
> I think you need to update
>
LayoutTests/platform/*/virtual/stable/webexposed/global-interface-listing-expected.txt
> too.

Thanks. I'll try to fix them. It looks like we have two files to fix; Win/Linux.
https://cs.chromium.org/search/?q=global-interface-listing-expected+file:%5Es...

[hongchan, 2016-11-09 18:21:11]

The CQ bit was checked by hongchan@chromium.org

[hongchan, 2016-11-09 18:21:11]

The patchset sent to the CQ was uploaded after l-g-t-m from rtoy@chromium.org,
tkent@chromium.org
Link to the patchset: https://codereview.chromium.org/2386303002/#ps320001
(title: "Fixing platform-dependent interface (2)")

[commit-bot: I haz the power, 2016-11-09 18:21:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-09 19:28:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-09 19:28:43]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[hongchan, 2016-11-09 19:35:49]

The CQ bit was checked by hongchan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-09 19:36:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-09 20:38:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-09 20:38:25]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[hongchan, 2016-11-09 23:20:27]

The CQ bit was checked by hongchan@chromium.org

[hongchan, 2016-11-09 23:20:28]

The patchset sent to the CQ was uploaded after l-g-t-m from tkent@chromium.org,
rtoy@chromium.org
Link to the patchset: https://codereview.chromium.org/2386303002/#ps340001
(title: "fixed cross-origin-objects")

[commit-bot: I haz the power, 2016-11-09 23:21:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-10 00:40:33]

Description was changed from

==========
Expose BaseAudioContext prototype

Refactoring of BaseAudioContext (https://codereview.chromium.org/1865583002)
changed the prototype structure of AudioContext/OfflineAudioContext and
developers could not call hasOwnProperty() on BaseAudioContext because
it was not exposed to the JS domain.

This CL exposes BaseAudioContext's prototype. Also it adds 3 new layout
tests for each audio context and removes the old context property test.

BUG=555608, 661637
TEST=
LayoutTests/webaudio/baseaudiocontext-properties.html
LayoutTests/webaudio/audiocontext-properties.html
LayoutTests/webaudio/offlineaudiocontext-properties.html
==========

to

==========
Expose BaseAudioContext prototype

Refactoring of BaseAudioContext (https://codereview.chromium.org/1865583002)
changed the prototype structure of AudioContext/OfflineAudioContext and
developers could not call hasOwnProperty() on BaseAudioContext because
it was not exposed to the JS domain.

This CL exposes BaseAudioContext's prototype. Also it adds 3 new layout
tests for each audio context and removes the old context property test.

BUG=555608, 661637
TEST=
LayoutTests/webaudio/baseaudiocontext-properties.html
LayoutTests/webaudio/audiocontext-properties.html
LayoutTests/webaudio/offlineaudiocontext-properties.html
==========

[commit-bot: I haz the power, 2016-11-10 00:40:34]

Committed patchset #14 (id:340001)

[commit-bot: I haz the power, 2016-11-10 00:45:26]

Description was changed from

==========
Expose BaseAudioContext prototype

Refactoring of BaseAudioContext (https://codereview.chromium.org/1865583002)
changed the prototype structure of AudioContext/OfflineAudioContext and
developers could not call hasOwnProperty() on BaseAudioContext because
it was not exposed to the JS domain.

This CL exposes BaseAudioContext's prototype. Also it adds 3 new layout
tests for each audio context and removes the old context property test.

BUG=555608, 661637
TEST=
LayoutTests/webaudio/baseaudiocontext-properties.html
LayoutTests/webaudio/audiocontext-properties.html
LayoutTests/webaudio/offlineaudiocontext-properties.html
==========

to

==========
Expose BaseAudioContext prototype

Refactoring of BaseAudioContext (https://codereview.chromium.org/1865583002)
changed the prototype structure of AudioContext/OfflineAudioContext and
developers could not call hasOwnProperty() on BaseAudioContext because
it was not exposed to the JS domain.

This CL exposes BaseAudioContext's prototype. Also it adds 3 new layout
tests for each audio context and removes the old context property test.

BUG=555608, 661637
TEST=
LayoutTests/webaudio/baseaudiocontext-properties.html
LayoutTests/webaudio/audiocontext-properties.html
LayoutTests/webaudio/offlineaudiocontext-properties.html

Committed: https://crrev.com/5ec22676c144539f37f15740f4d712bb298ea02a
Cr-Commit-Position: refs/heads/master@{#431105}
==========

[commit-bot: I haz the power, 2016-11-10 00:45:27]

Patchset 14 (id:??) landed as
https://crrev.com/5ec22676c144539f37f15740f4d712bb298ea02a
Cr-Commit-Position: refs/heads/master@{#431105}