Implement BaseAudioContext

Implement BaseAudioContext

Implements BaseAudioContext as the base class of an AudioContext and
OfflineAudioContext, moving the relevant attributes and methods from
AudioContext to BaseAudioContext.

The changes in the expected results are mostly caused by exception
messages now saying BaseAudioContext instead of AudioContext.

BUG=555608
TEST=no new tests

Committed: https://crrev.com/528d8818a3528b4372ab18b5a7ecdb906dadca75
Cr-Commit-Position: refs/heads/master@{#417297}

[Raymond Toy, 2016-07-26 16:50:25]

The CQ bit was checked by rtoy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-26 16:50:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-26 17:15:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-26 17:15:46]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[Raymond Toy, 2016-08-05 15:02:46]

The CQ bit was checked by rtoy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-05 15:03:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-05 16:10:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-05 16:10:28]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Raymond Toy, 2016-08-16 16:28:59]

The CQ bit was checked by rtoy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-16 16:29:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-16 17:22:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-16 17:22:06]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Raymond Toy, 2016-09-01 17:01:49]

The CQ bit was checked by rtoy@chromium.org to run a CQ dry run

[Raymond Toy, 2016-09-01 17:02:13]

rtoy@chromium.org changed reviewers:
+ hochchan@chromium.org

[Raymond Toy, 2016-09-01 17:02:15]

PTAL

[commit-bot: I haz the power, 2016-09-01 17:02:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Raymond Toy, 2016-09-01 17:02:44]

Description was changed from

==========
Implement BaseAudioContext

WIP

Implements BaseAudioContext as the base class of an AudioContext and
OfflineAudioContext.  Most of the changes consists of a mechanical
renaming of AbstractAudioContext to BaseAudioContext.

Most methods moved to BaseAudioContext since they apply to both
AudioContext and OfflineAudioContext.  However, the createMedia*
methods stay in AudioContext since OfflineAudioContexts do not allow
these.


BUG=555608
TEST=no new tests
==========

to

==========
Implement BaseAudioContext

WIP

Implements BaseAudioContext as the base class of an AudioContext and
OfflineAudioContext.  Most of the changes consists of a mechanical
renaming of AbstractAudioContext to BaseAudioContext.


BUG=555608
TEST=no new tests
==========

[commit-bot: I haz the power, 2016-09-01 18:39:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-01 18:39:05]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[hongchan, 2016-09-01 19:05:18]

On 2016/09/01 17:02:15, Raymond Toy wrote:
> PTAL

Same thing. Please fix the reviewer to 'hongchan'. :)

[Raymond Toy, 2016-09-01 19:53:56]

rtoy@chromium.org changed reviewers:
+ hongchan@chromium.org
- hochchan@chromium.org

[Raymond Toy, 2016-09-01 19:54:12]

Description was changed from

==========
Implement BaseAudioContext

WIP

Implements BaseAudioContext as the base class of an AudioContext and
OfflineAudioContext.  Most of the changes consists of a mechanical
renaming of AbstractAudioContext to BaseAudioContext.


BUG=555608
TEST=no new tests
==========

to

==========
Implement BaseAudioContext

Implements BaseAudioContext as the base class of an AudioContext and
OfflineAudioContext.  Most of the changes consists of a mechanical
renaming of AbstractAudioContext to BaseAudioContext.


BUG=555608
TEST=no new tests
==========

[hongchan, 2016-09-01 20:39:44]

https://codereview.chromium.org/1865583002/diff/280001/third_party/WebKit/Lay...
File
third_party/WebKit/LayoutTests/virtual/stable/webexposed/event-target-in-prototype-expected.txt
(left):

https://codereview.chromium.org/1865583002/diff/280001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/virtual/stable/webexposed/event-target-in-prototype-expected.txt:15:
PASS AudioContext.prototype.__proto__ is EventTarget.prototype
Shouldn't we be adding one for BaseAudioContext?

https://codereview.chromium.org/1865583002/diff/280001/third_party/WebKit/Lay...
File
third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt
(left):

https://codereview.chromium.org/1865583002/diff/280001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt:6723:

Just curious. Is this an artifact from git cl format?

https://codereview.chromium.org/1865583002/diff/280001/third_party/WebKit/Lay...
File
third_party/WebKit/LayoutTests/webaudio/audiochannelmerger-basic-expected.txt
(right):

https://codereview.chromium.org/1865583002/diff/280001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/webaudio/audiochannelmerger-basic-expected.txt:7:
PASS context.createChannelMerger(0) threw IndexSizeError: Failed to execute
'createChannelMerger' on 'BaseAudioContext': The number of inputs provided (0)
is outside the range [1, 32]..
Not sure if this is correct. If you're using AudioContext, I think you should
get AudioContext.

https://codereview.chromium.org/1865583002/diff/280001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/webaudio/audiochannelmerger-basic-expected.txt:9:
PASS context.createChannelMerger(33) threw IndexSizeError: Failed to execute
'createChannelMerger' on 'BaseAudioContext': The number of inputs provided (33)
is outside the range [1, 32]..
Ditto to all the other test results.

https://codereview.chromium.org/1865583002/diff/280001/third_party/WebKit/Lay...
File third_party/WebKit/LayoutTests/webaudio/audioparam-nominal-range.html
(right):

https://codereview.chromium.org/1865583002/diff/280001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/webaudio/audioparam-nominal-range.html:213: //
Can't currently test because we're using an offline context.
... test MediaStreamSource because...

https://codereview.chromium.org/1865583002/diff/280001/third_party/WebKit/Lay...
File third_party/WebKit/LayoutTests/webexposed/event-target-in-prototype.html
(right):

https://codereview.chromium.org/1865583002/diff/280001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/webexposed/event-target-in-prototype.html:9:
eventTargets = ['EventSource', 'FileReader', 'MediaSource', 'MessagePort',
'Node', 'Performance', 'SharedWorker', 'WebSocket', 'Worker'];
We don't check BaseAudioContext because it cannot be instantiated
programmatically?

https://codereview.chromium.org/1865583002/diff/280001/third_party/WebKit/Sou...
File third_party/WebKit/Source/modules/webaudio/BaseAudioContext.idl (right):

https://codereview.chromium.org/1865583002/diff/280001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/webaudio/BaseAudioContext.idl:66: // here so
we can use an offline audio context to test these.
I think the tests in this CL is using AudioContext to check these out instead of
OfflineAudioContext. No?

[Raymond Toy, 2016-09-01 20:51:37]

https://codereview.chromium.org/1865583002/diff/280001/third_party/WebKit/Lay...
File
third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt
(left):

https://codereview.chromium.org/1865583002/diff/280001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt:6723:

On 2016/09/01 at 20:39:44, hoch wrote:
> Just curious. Is this an artifact from git cl format?

What?  That line 6723 was deleted? I don't know.

https://codereview.chromium.org/1865583002/diff/280001/third_party/WebKit/Lay...
File
third_party/WebKit/LayoutTests/webaudio/audiochannelmerger-basic-expected.txt
(right):

https://codereview.chromium.org/1865583002/diff/280001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/webaudio/audiochannelmerger-basic-expected.txt:7:
PASS context.createChannelMerger(0) threw IndexSizeError: Failed to execute
'createChannelMerger' on 'BaseAudioContext': The number of inputs provided (0)
is outside the range [1, 32]..
On 2016/09/01 at 20:39:44, hoch wrote:
> Not sure if this is correct. If you're using AudioContext, I think you should
get AudioContext.

This is auto-generated from the exception handler.  The current method is the
BaseAudioContext method.

https://codereview.chromium.org/1865583002/diff/280001/third_party/WebKit/Lay...
File third_party/WebKit/LayoutTests/webexposed/event-target-in-prototype.html
(right):

https://codereview.chromium.org/1865583002/diff/280001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/webexposed/event-target-in-prototype.html:9:
eventTargets = ['EventSource', 'FileReader', 'MediaSource', 'MessagePort',
'Node', 'Performance', 'SharedWorker', 'WebSocket', 'Worker'];
On 2016/09/01 at 20:39:44, hoch wrote:
> We don't check BaseAudioContext because it cannot be instantiated
programmatically?

Yes, I think so; BaseAudioContext can't be constructed directly.

https://codereview.chromium.org/1865583002/diff/280001/third_party/WebKit/Sou...
File third_party/WebKit/Source/modules/webaudio/BaseAudioContext.idl (right):

https://codereview.chromium.org/1865583002/diff/280001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/webaudio/BaseAudioContext.idl:66: // here so
we can use an offline audio context to test these.
On 2016/09/01 at 20:39:44, hoch wrote:
> I think the tests in this CL is using AudioContext to check these out instead
of OfflineAudioContext. No?

It's the CORS tests that use the offline audio context to run
MediaStreamAudioSource. I didn't touch those tests so they won't show up here.

[hongchan, 2016-09-01 23:03:19]

https://codereview.chromium.org/1865583002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/webaudio/AudioNode.idl (right):

https://codereview.chromium.org/1865583002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/webaudio/AudioNode.idl:39: GarbageCollected,
Why this change?

https://codereview.chromium.org/1865583002/diff/280001/third_party/WebKit/Lay...
File
third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt
(left):

https://codereview.chromium.org/1865583002/diff/280001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt:6723:

On 2016/09/01 20:51:37, Raymond Toy wrote:
> On 2016/09/01 at 20:39:44, hoch wrote:
> > Just curious. Is this an artifact from git cl format?
> 
> What?  That line 6723 was deleted? I don't know.

I suggest you to leave this line as it is since this file is touched by multiple
engineers. Applying `git cl format` might be the right thing to do.

https://codereview.chromium.org/1865583002/diff/280001/third_party/WebKit/Lay...
File
third_party/WebKit/LayoutTests/webexposed/event-target-in-prototype-expected.txt
(left):

https://codereview.chromium.org/1865583002/diff/280001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/webexposed/event-target-in-prototype-expected.txt:15:
PASS AudioContext.prototype.__proto__ is EventTarget.prototype
I think we still need this here. Plus OfflineAudioContext.

https://codereview.chromium.org/1865583002/diff/280001/third_party/WebKit/Lay...
File third_party/WebKit/LayoutTests/webexposed/event-target-in-prototype.html
(right):

https://codereview.chromium.org/1865583002/diff/280001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/webexposed/event-target-in-prototype.html:9:
eventTargets = ['EventSource', 'FileReader', 'MediaSource', 'MessagePort',
'Node', 'Performance', 'SharedWorker', 'WebSocket', 'Worker'];
On 2016/09/01 20:51:37, Raymond Toy wrote:
> On 2016/09/01 at 20:39:44, hoch wrote:
> > We don't check BaseAudioContext because it cannot be instantiated
> programmatically?
> 
> Yes, I think so; BaseAudioContext can't be constructed directly.

If so, shouldn't we still have AudioContext and OfflineAudioContext here? They
are constructable event targets.

https://codereview.chromium.org/1865583002/diff/300001/third_party/WebKit/Lay...
File third_party/WebKit/LayoutTests/webexposed/event-target-in-prototype.html
(right):

https://codereview.chromium.org/1865583002/diff/300001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/webexposed/event-target-in-prototype.html:10:
'Node', 'Performance', 'SharedWorker', 'WebSocket', 'Worker',
'BaseAudioContext'];
Hmm. Does this work? Now I am more confused.

[haraken, 2016-09-01 23:05:54]

haraken@chromium.org changed reviewers:
+ haraken@chromium.org

[haraken, 2016-09-01 23:05:56]

https://codereview.chromium.org/1865583002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/webaudio/AudioNode.idl (right):

https://codereview.chromium.org/1865583002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/webaudio/AudioNode.idl:39: GarbageCollected,
On 2016/09/01 23:03:19, hoch wrote:
> Why this change?

Maybe you're using a very old AudioNode.idl? [GarbageCollected] is gone a long
time ago.

[Raymond Toy, 2016-09-02 15:00:49]

On 2016/09/01 at 23:05:56, haraken wrote:
>
https://codereview.chromium.org/1865583002/diff/40001/third_party/WebKit/Sour...
> File third_party/WebKit/Source/modules/webaudio/AudioNode.idl (right):
> 
>
https://codereview.chromium.org/1865583002/diff/40001/third_party/WebKit/Sour...
> third_party/WebKit/Source/modules/webaudio/AudioNode.idl:39: GarbageCollected,
> On 2016/09/01 23:03:19, hoch wrote:
> > Why this change?
> 
> Maybe you're using a very old AudioNode.idl? [GarbageCollected] is gone a long
time ago.

What's displayed here and what the link actually goes to seems inconsistent.
There is no GarbageCollected
in the linked line or in the idl file either.

[Raymond Toy, 2016-09-02 15:07:14]

On 2016/09/01 at 23:03:19, hongchan wrote:
>
https://codereview.chromium.org/1865583002/diff/40001/third_party/WebKit/Sour...
> File third_party/WebKit/Source/modules/webaudio/AudioNode.idl (right):
> 
>
https://codereview.chromium.org/1865583002/diff/40001/third_party/WebKit/Sour...
> third_party/WebKit/Source/modules/webaudio/AudioNode.idl:39: GarbageCollected,
> Why this change?

Can you clarify this? What change are you talking about here?
> 
>
https://codereview.chromium.org/1865583002/diff/280001/third_party/WebKit/Lay...
> File
third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt
(left):
> 
>
https://codereview.chromium.org/1865583002/diff/280001/third_party/WebKit/Lay...
>
third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt:6723:

> On 2016/09/01 20:51:37, Raymond Toy wrote:
> > On 2016/09/01 at 20:39:44, hoch wrote:
> > > Just curious. Is this an artifact from git cl format?
> > 
> > What?  That line 6723 was deleted? I don't know.
> 
> I suggest you to leave this line as it is since this file is touched by
multiple engineers. Applying `git cl format` might be the right thing to do.
> 
>
https://codereview.chromium.org/1865583002/diff/280001/third_party/WebKit/Lay...
> File
third_party/WebKit/LayoutTests/webexposed/event-target-in-prototype-expected.txt
(left):
> 
>
https://codereview.chromium.org/1865583002/diff/280001/third_party/WebKit/Lay...
>
third_party/WebKit/LayoutTests/webexposed/event-target-in-prototype-expected.txt:15:
PASS AudioContext.prototype.__proto__ is EventTarget.prototype
> I think we still need this here. Plus OfflineAudioContext.
> 
>
https://codereview.chromium.org/1865583002/diff/280001/third_party/WebKit/Lay...
> File third_party/WebKit/LayoutTests/webexposed/event-target-in-prototype.html
(right):
> 
>
https://codereview.chromium.org/1865583002/diff/280001/third_party/WebKit/Lay...
> third_party/WebKit/LayoutTests/webexposed/event-target-in-prototype.html:9:
eventTargets = ['EventSource', 'FileReader', 'MediaSource', 'MessagePort',
'Node', 'Performance', 'SharedWorker', 'WebSocket', 'Worker'];
> On 2016/09/01 20:51:37, Raymond Toy wrote:
> > On 2016/09/01 at 20:39:44, hoch wrote:
> > > We don't check BaseAudioContext because it cannot be instantiated
> > programmatically?
> > 
> > Yes, I think so; BaseAudioContext can't be constructed directly.
> 
> If so, shouldn't we still have AudioContext and OfflineAudioContext here? They
are constructable event targets.
> 
>
https://codereview.chromium.org/1865583002/diff/300001/third_party/WebKit/Lay...
> File third_party/WebKit/LayoutTests/webexposed/event-target-in-prototype.html
(right):
> 
>
https://codereview.chromium.org/1865583002/diff/300001/third_party/WebKit/Lay...
> third_party/WebKit/LayoutTests/webexposed/event-target-in-prototype.html:10:
'Node', 'Performance', 'SharedWorker', 'WebSocket', 'Worker',
'BaseAudioContext'];
> Hmm. Does this work? Now I am more confused.

[Raymond Toy, 2016-09-02 15:16:40]

On 2016/09/01 at 23:03:19, hongchan wrote:
>
https://codereview.chromium.org/1865583002/diff/40001/third_party/WebKit/Sour...
> File third_party/WebKit/Source/modules/webaudio/AudioNode.idl (right):
> 
>
https://codereview.chromium.org/1865583002/diff/40001/third_party/WebKit/Sour...
> third_party/WebKit/Source/modules/webaudio/AudioNode.idl:39: GarbageCollected,
> Why this change?
> 
>
https://codereview.chromium.org/1865583002/diff/280001/third_party/WebKit/Lay...
> File
third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt
(left):
> 
>
https://codereview.chromium.org/1865583002/diff/280001/third_party/WebKit/Lay...
>
third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt:6723:

> On 2016/09/01 20:51:37, Raymond Toy wrote:
> > On 2016/09/01 at 20:39:44, hoch wrote:
> > > Just curious. Is this an artifact from git cl format?
> > 
> > What?  That line 6723 was deleted? I don't know.
> 
> I suggest you to leave this line as it is since this file is touched by
multiple engineers. Applying `git cl format` might be the right thing to do.

This should be fixed now.

> 
>
https://codereview.chromium.org/1865583002/diff/280001/third_party/WebKit/Lay...
> File
third_party/WebKit/LayoutTests/webexposed/event-target-in-prototype-expected.txt
(left):
> 
>
https://codereview.chromium.org/1865583002/diff/280001/third_party/WebKit/Lay...
>
third_party/WebKit/LayoutTests/webexposed/event-target-in-prototype-expected.txt:15:
PASS AudioContext.prototype.__proto__ is EventTarget.prototype
> I think we still need this here. Plus OfflineAudioContext.

With this CL, AudioContext.prototype.__proto__ is BaseAudioContext, as is
OfflineAudioContext.prototype.__proto__.

Also, I guess since BaseAudioContext isn't constructible, it doesn't have a
prototype. (At least entering
BaseAudioContext.prototype in the console produces an error.)
 
> 
>
https://codereview.chromium.org/1865583002/diff/280001/third_party/WebKit/Lay...
> File third_party/WebKit/LayoutTests/webexposed/event-target-in-prototype.html
(right):
> 
>
https://codereview.chromium.org/1865583002/diff/280001/third_party/WebKit/Lay...
> third_party/WebKit/LayoutTests/webexposed/event-target-in-prototype.html:9:
eventTargets = ['EventSource', 'FileReader', 'MediaSource', 'MessagePort',
'Node', 'Performance', 'SharedWorker', 'WebSocket', 'Worker'];
> On 2016/09/01 20:51:37, Raymond Toy wrote:
> > On 2016/09/01 at 20:39:44, hoch wrote:
> > > We don't check BaseAudioContext because it cannot be instantiated
> > programmatically?
> > 
> > Yes, I think so; BaseAudioContext can't be constructed directly.
> 
> If so, shouldn't we still have AudioContext and OfflineAudioContext here? They
are constructable event targets.
> 
>
https://codereview.chromium.org/1865583002/diff/300001/third_party/WebKit/Lay...
> File third_party/WebKit/LayoutTests/webexposed/event-target-in-prototype.html
(right):
> 
>
https://codereview.chromium.org/1865583002/diff/300001/third_party/WebKit/Lay...
> third_party/WebKit/LayoutTests/webexposed/event-target-in-prototype.html:10:
'Node', 'Performance', 'SharedWorker', 'WebSocket', 'Worker',
'BaseAudioContext'];
> Hmm. Does this work? Now I am more confused.

Yeah, that was a test.  I see now that eventTarget[i] must be in the window for
the prototype test to run.  And BaseAudioContext is not in window.

[hongchan, 2016-09-02 16:49:34]

LGTM with nits.

https://codereview.chromium.org/1865583002/diff/320001/third_party/WebKit/Lay...
File third_party/WebKit/LayoutTests/webexposed/event-target-in-prototype.html
(right):

https://codereview.chromium.org/1865583002/diff/320001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/webexposed/event-target-in-prototype.html:10:
'Node', 'Performance', 'SharedWorker', 'WebSocket', 'Worker',
'BaseAudioContext'];
If this does not show up in the expected file, perhaps we should remove this
from here as well?

https://codereview.chromium.org/1865583002/diff/320001/third_party/WebKit/Sou...
File third_party/WebKit/Source/modules/webaudio/AudioNode.idl (right):

https://codereview.chromium.org/1865583002/diff/320001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/webaudio/AudioNode.idl:49: readonly attribute
BaseAudioContext  context;
Perhaps we can delete extra space after BaseAudioContext?

[Raymond Toy, 2016-09-02 17:24:44]

https://codereview.chromium.org/1865583002/diff/320001/third_party/WebKit/Lay...
File third_party/WebKit/LayoutTests/webexposed/event-target-in-prototype.html
(right):

https://codereview.chromium.org/1865583002/diff/320001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/webexposed/event-target-in-prototype.html:10:
'Node', 'Performance', 'SharedWorker', 'WebSocket', 'Worker',
'BaseAudioContext'];
On 2016/09/02 at 16:49:34, hoch wrote:
> If this does not show up in the expected file, perhaps we should remove this
from here as well?

Yeah, I'm removing in the next patch.

[Raymond Toy, 2016-09-02 18:22:51]

The CQ bit was checked by rtoy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-02 18:23:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Raymond Toy, 2016-09-02 18:34:40]

The CQ bit was unchecked by rtoy@chromium.org

[Raymond Toy, 2016-09-02 18:35:29]

The CQ bit was checked by rtoy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-02 18:36:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Raymond Toy, 2016-09-02 20:11:07]

Description was changed from

==========
Implement BaseAudioContext

Implements BaseAudioContext as the base class of an AudioContext and
OfflineAudioContext.  Most of the changes consists of a mechanical
renaming of AbstractAudioContext to BaseAudioContext.


BUG=555608
TEST=no new tests
==========

to

==========
Implement BaseAudioContext

Implements BaseAudioContext as the base class of an AudioContext and
OfflineAudioContext, moving the relevant attributes and methods from 
AudioContext to BaseAudioContext.

The changes in the expected results are mostly caused by exception
messages now saying BaseAudioContext instead of AudioContext.

BUG=555608
TEST=no new tests
==========

[commit-bot: I haz the power, 2016-09-02 20:15:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-02 20:15:07]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[Raymond Toy, 2016-09-06 16:24:46]

rtoy@chromium.org changed reviewers:
+ tkent@chromium.org

[Raymond Toy, 2016-09-06 16:24:47]

+tkent

PTAL as API owner.  This is a relatively small change, adding BaseAudioContext
class as the base class for AudioContext and OfflineAudioContext.  I didn't
write an intent or anything.  Should I?

[tkent, 2016-09-06 23:14:34]

On 2016/09/06 at 16:24:47, rtoy wrote:
> +tkent
> 
> PTAL as API owner.  This is a relatively small change, adding BaseAudioContext
class as the base class for AudioContext and OfflineAudioContext.  I didn't
write an intent or anything.  Should I?

IMO, we may skip intent-to-ship because this is almost user-invisible. However,
we should have a chromestatus.com entry for the record.

https://codereview.chromium.org/1865583002/diff/360001/third_party/WebKit/Lay...
File third_party/WebKit/LayoutTests/webexposed/event-target-in-prototype.html
(left):

https://codereview.chromium.org/1865583002/diff/360001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/webexposed/event-target-in-prototype.html:9:
eventTargets = ['EventSource', 'FileReader', 'MediaSource', 'MessagePort',
'Node', 'Performance', 'SharedWorker', 'WebSocket', 'Worker', 'AudioContext'];
Don't you test BaseAudioContext?

https://codereview.chromium.org/1865583002/diff/360001/third_party/WebKit/Lay...
File third_party/WebKit/LayoutTests/webexposed/event-target-in-prototype.html
(right):

https://codereview.chromium.org/1865583002/diff/360001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/webexposed/event-target-in-prototype.html:10:
'Node', 'Performance', 'SharedWorker', 'WebSocket', 'Worker'];
Add indentation.

https://codereview.chromium.org/1865583002/diff/360001/third_party/WebKit/Sou...
File third_party/WebKit/Source/modules/webaudio/BaseAudioContext.idl (right):

https://codereview.chromium.org/1865583002/diff/360001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/webaudio/BaseAudioContext.idl:4: 
Let's add a spec URL. https://webaudio.github.io/web-audio-api/#BaseAudioContext
?

[Raymond Toy, 2016-09-07 15:44:21]

https://codereview.chromium.org/1865583002/diff/360001/third_party/WebKit/Lay...
File third_party/WebKit/LayoutTests/webexposed/event-target-in-prototype.html
(left):

https://codereview.chromium.org/1865583002/diff/360001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/webexposed/event-target-in-prototype.html:9:
eventTargets = ['EventSource', 'FileReader', 'MediaSource', 'MessagePort',
'Node', 'Performance', 'SharedWorker', 'WebSocket', 'Worker', 'AudioContext'];
On 2016/09/06 23:14:33, tkent wrote:
> Don't you test BaseAudioContext?

I believe this doesn't matter.  BaseAudioContext isn't constructable so
window.BaseAudioContext doesn't exist. (Which is what the test is looking for
before testing.)

[Raymond Toy, 2016-09-07 15:44:51]

On 2016/09/06 23:14:34, tkent wrote:
> On 2016/09/06 at 16:24:47, rtoy wrote:
> > +tkent
> > 
> > PTAL as API owner.  This is a relatively small change, adding
BaseAudioContext
> class as the base class for AudioContext and OfflineAudioContext.  I didn't
> write an intent or anything.  Should I?
> 
> IMO, we may skip intent-to-ship because this is almost user-invisible.
However,
> we should have a http://chromestatus.com entry for the record.

Done: https://www.chromestatus.com/feature/5671957710241792

> 
>
https://codereview.chromium.org/1865583002/diff/360001/third_party/WebKit/Lay...
> File third_party/WebKit/LayoutTests/webexposed/event-target-in-prototype.html
> (left):
> 
>
https://codereview.chromium.org/1865583002/diff/360001/third_party/WebKit/Lay...
> third_party/WebKit/LayoutTests/webexposed/event-target-in-prototype.html:9:
> eventTargets = ['EventSource', 'FileReader', 'MediaSource', 'MessagePort',
> 'Node', 'Performance', 'SharedWorker', 'WebSocket', 'Worker', 'AudioContext'];
> Don't you test BaseAudioContext?
> 
>
https://codereview.chromium.org/1865583002/diff/360001/third_party/WebKit/Lay...
> File third_party/WebKit/LayoutTests/webexposed/event-target-in-prototype.html
> (right):
> 
>
https://codereview.chromium.org/1865583002/diff/360001/third_party/WebKit/Lay...
> third_party/WebKit/LayoutTests/webexposed/event-target-in-prototype.html:10:
> 'Node', 'Performance', 'SharedWorker', 'WebSocket', 'Worker'];
> Add indentation.
> 
>
https://codereview.chromium.org/1865583002/diff/360001/third_party/WebKit/Sou...
> File third_party/WebKit/Source/modules/webaudio/BaseAudioContext.idl (right):
> 
>
https://codereview.chromium.org/1865583002/diff/360001/third_party/WebKit/Sou...
> third_party/WebKit/Source/modules/webaudio/BaseAudioContext.idl:4: 
> Let's add a spec URL.
https://webaudio.github.io/web-audio-api/#BaseAudioContext
> ?

[Raymond Toy, 2016-09-07 15:51:49]

https://codereview.chromium.org/1865583002/diff/360001/third_party/WebKit/Lay...
File third_party/WebKit/LayoutTests/webexposed/event-target-in-prototype.html
(right):

https://codereview.chromium.org/1865583002/diff/360001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/webexposed/event-target-in-prototype.html:10:
'Node', 'Performance', 'SharedWorker', 'WebSocket', 'Worker'];
On 2016/09/06 23:14:33, tkent wrote:
> Add indentation.

Done.

https://codereview.chromium.org/1865583002/diff/360001/third_party/WebKit/Sou...
File third_party/WebKit/Source/modules/webaudio/BaseAudioContext.idl (right):

https://codereview.chromium.org/1865583002/diff/360001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/webaudio/BaseAudioContext.idl:4: 
On 2016/09/06 23:14:33, tkent wrote:
> Let's add a spec URL.
https://webaudio.github.io/web-audio-api/#BaseAudioContext
> ?

Done.

[Raymond Toy, 2016-09-07 15:52:03]

The CQ bit was checked by rtoy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-07 15:52:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-07 17:30:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-07 17:30:48]

Dry run: This issue passed the CQ dry run.

[Raymond Toy, 2016-09-07 22:50:33]

The CQ bit was checked by rtoy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-07 22:51:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tkent, 2016-09-08 00:07:10]

web-exposed change without intent-to-ship LGTM

[commit-bot: I haz the power, 2016-09-08 00:22:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-08 00:22:55]

Dry run: This issue passed the CQ dry run.

[Raymond Toy, 2016-09-08 15:09:21]

The CQ bit was checked by rtoy@chromium.org

[Raymond Toy, 2016-09-08 15:09:21]

The patchset sent to the CQ was uploaded after l-g-t-m from
hongchan@chromium.org
Link to the patchset: https://codereview.chromium.org/1865583002/#ps400001
(title: "Rebase")

[commit-bot: I haz the power, 2016-09-08 15:09:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-08 15:13:50]

Committed patchset #21 (id:400001)

[commit-bot: I haz the power, 2016-09-08 15:16:36]

Description was changed from

==========
Implement BaseAudioContext

Implements BaseAudioContext as the base class of an AudioContext and
OfflineAudioContext, moving the relevant attributes and methods from 
AudioContext to BaseAudioContext.

The changes in the expected results are mostly caused by exception
messages now saying BaseAudioContext instead of AudioContext.

BUG=555608
TEST=no new tests
==========

to

==========
Implement BaseAudioContext

Implements BaseAudioContext as the base class of an AudioContext and
OfflineAudioContext, moving the relevant attributes and methods from
AudioContext to BaseAudioContext.

The changes in the expected results are mostly caused by exception
messages now saying BaseAudioContext instead of AudioContext.

BUG=555608
TEST=no new tests

Committed: https://crrev.com/528d8818a3528b4372ab18b5a7ecdb906dadca75
Cr-Commit-Position: refs/heads/master@{#417297}
==========

[commit-bot: I haz the power, 2016-09-08 15:16:37]

Patchset 21 (id:??) landed as
https://crrev.com/528d8818a3528b4372ab18b5a7ecdb906dadca75
Cr-Commit-Position: refs/heads/master@{#417297}