third_party/WebKit/LayoutTests/webaudio/audiocontext-properties.html - Issue 2386303002: Expose BaseAudioContext prototype

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/webaudio/audiocontext-properties.html

Issue 2386303002: Expose BaseAudioContext prototype (Closed)

Patch Set: Rebase Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/webaudio/baseaudiocontext-properties.html » ('j') | third_party/WebKit/LayoutTests/webaudio/resources/context-properties.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <html>

	3 <head>

	4 <title>Testing AudioContext properties</title>

	5 <script src="../resources/testharness.js"></script>

	6 <script src="../resources/testharnessreport.js"></script>

	7 <script src="resources/audio-testing.js"></script>

	8 <script src="resources/context-properties.js"></script>

	9 </head>

	10 <body>

	11 <script>

	12 var audit = Audit.createTaskRunner();

	13

	14

	15 audit.defineTask('audiocontext-properties', function (taskDone) {

	16

	17 // Check the properties that belongs to AC.

	18 checkContextProperties({

	19 targetPrototype: AudioContext.prototype,

	20 targetDescription: 'AudioContext.prototype',
	Raymond Toy 2016/11/02 22:10:09 Can't you just print out targetPrototype name in t Can't you just print out targetPrototype name in the test so you don't have to duplicate it with targetDescription? hongchan 2016/11/02 22:46:50 How can I do that? Just curious. I am not sure how Show quoted text On 2016/11/02 22:10:09, Raymond Toy wrote: > Can't you just print out targetPrototype name in the test so you don't have to > duplicate it with targetDescription? How can I do that? Just curious. I am not sure how I can query the name (string) of a prototype object. I can certainly do some string manipulation to extract the name of the object, but I think that's over-engineering unless you want to use somewhere else. Raymond Toy 2016/11/02 23:01:07 Maybe set targetPrototype to "AudioContext", and u Show quoted text On 2016/11/02 22:46:50, hongchan wrote: > On 2016/11/02 22:10:09, Raymond Toy wrote: > > Can't you just print out targetPrototype name in the test so you don't have to > > duplicate it with targetDescription? > > How can I do that? Just curious. I am not sure how I can query the name (string) > of a prototype object. I can certainly do some string manipulation to extract > the name of the object, but I think that's over-engineering unless you want to > use somewhere else. Maybe set targetPrototype to "AudioContext", and use window[targetPrototype].prototype to get the prototype and use it for printing the description. Of course, if you do this, rename targetPrototype to targetContext or something.
	21 propertyDict: AudioContextOwnProperties,

	22 expected: true

	23 }, Should);

	24

	25 // Check the properties that only belongs to OAC.

	26 checkContextProperties({

	27 targetPrototype: AudioContext.prototype,

	28 targetDescription: 'AudioContext.prototype',

	29 propertyDict: OfflineAudioContextOwnProperties,

	30 expected: false

	31 }, Should);

	32

	33 taskDone();

	34 });

	35

	36

	37 audit.runTasks();

	38 </script>

	39 </body>

	40 </html>

OLD	NEW