third_party/WebKit/LayoutTests/webaudio/context-properties.html - Issue 2386303002: Expose BaseAudioContext prototype

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/webaudio/context-properties.html

Issue 2386303002: Expose BaseAudioContext prototype (Closed)

Patch Set: Removes old context property test Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/webaudio/baseaudiocontext-properties.html ('k') | third_party/WebKit/LayoutTests/webaudio/context-properties-expected.txt » ('j') | third_party/WebKit/LayoutTests/webaudio/resources/context-properties.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
	(Empty)
1 <!DOCTYPE html>

2 <html>

3 <head>

4 <script src="resources/compatibility.js"></script>

5 <script src="../resources/js-test.js"></script>

6 </head>

7

8 <body>

9 <script>

10 description("Tests audio context for offline attributes and methods.");

11

12 function runTest() {

13 // Create an online and offline context for testing.

14 onlineContext = new AudioContext();

15 offlineContext = new OfflineAudioContext(1, 1000, 44100);

16

17 // The online context cannot have oncomplete and startRendering

18 shouldBeUndefined("onlineContext.oncomplete");
Raymond Toy 2016/10/03 20:19:20 Haven't you reduced test coverage by deleting this Haven't you reduced test coverage by deleting this test? We don't test that an AudioContext doesn't have oncomplete and startRendering. hongchan 2016/10/03 20:31:19 This boils down to another question: do we need to Show quoted text On 2016/10/03 20:19:20, Raymond Toy wrote: > Haven't you reduced test coverage by deleting this test? We don't test that an > AudioContext doesn't have oncomplete and startRendering. This boils down to another question: do we need to cross-check all the properties against each other? For example, checking AC, OAC props against BAC? Raymond Toy 2016/10/03 20:36:38 Don't actually know. Probably should in the futur Show quoted text On 2016/10/03 20:31:19, hoch wrote: > On 2016/10/03 20:19:20, Raymond Toy wrote: > > Haven't you reduced test coverage by deleting this test? We don't test that > an > > AudioContext doesn't have oncomplete and startRendering. > > This boils down to another question: do we need to cross-check all the > properties against each other? For example, checking AC, OAC props against BAC? Don't actually know. Probably should in the future, but I'm ok for now if we just added one quick special test for AudioContext to check that these don't exist. (So we don't lose coverage.)
19 shouldBeUndefined("onlineContext.startRendering");

20

21 // The offline context must have oncomplete and startRendering

22 shouldBeDefined("offlineContext.oncomplete");

23 shouldBeDefined("offlineContext.startRendering");

24

25 }

26

27 runTest();

28 successfullyParsed = true;

29 </script>

30

31 </body>

32 </html>

OLD	NEW