Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1666)

Issue 2386143003: Make PageLoadMetricsObserver::OnStart return ObservePolicy (Closed)

Created:
4 years, 2 months ago by Charlie Harrison
Modified:
4 years, 2 months ago
Reviewers:
Bryan McQuade
CC:
chromium-reviews, csharrison+watch_chromium.org, loading-reviews+metrics_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make PageLoadMetricsObserver::OnStart return ObservePolicy BUG=647764 Committed: https://crrev.com/46595f8ee5878368274f99c9821940897c74b277 Cr-Commit-Position: refs/heads/master@{#422567}

Patch Set 1 #

Messages

Total messages: 11 (6 generated)
Charlie Harrison
bmcquade, PTAL? Sorry for the delay on this one.
4 years, 2 months ago (2016-10-03 21:26:56 UTC) #4
Bryan McQuade
LGTM, thanks!
4 years, 2 months ago (2016-10-03 22:08:16 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2386143003/1
4 years, 2 months ago (2016-10-03 22:09:24 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-03 22:28:54 UTC) #9
commit-bot: I haz the power
4 years, 2 months ago (2016-10-03 22:30:41 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/46595f8ee5878368274f99c9821940897c74b277
Cr-Commit-Position: refs/heads/master@{#422567}

Powered by Google App Engine
This is Rietveld 408576698