Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Unified Diff: chrome/browser/page_load_metrics/page_load_metrics_observer.h

Issue 2386143003: Make PageLoadMetricsObserver::OnStart return ObservePolicy (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/page_load_metrics/page_load_metrics_observer.h
diff --git a/chrome/browser/page_load_metrics/page_load_metrics_observer.h b/chrome/browser/page_load_metrics/page_load_metrics_observer.h
index e60224022ff447bb3ef0663ca1fc912163b4c09b..2646171ab4ef0a3018c8ccb80344bf64ca3e7dcd 100644
--- a/chrome/browser/page_load_metrics/page_load_metrics_observer.h
+++ b/chrome/browser/page_load_metrics/page_load_metrics_observer.h
@@ -149,9 +149,9 @@ class PageLoadMetricsObserver {
// committed page load at the time the navigation for navigation_handle was
// initiated, or the empty URL if there was no committed page load at the time
// the navigation was initiated.
- virtual void OnStart(content::NavigationHandle* navigation_handle,
- const GURL& currently_committed_url,
- bool started_in_foreground) {}
+ virtual ObservePolicy OnStart(content::NavigationHandle* navigation_handle,
+ const GURL& currently_committed_url,
+ bool started_in_foreground);
// OnRedirect is triggered when a page load redirects to another URL.
// The navigation handle holds relevant data for the navigation, but will

Powered by Google App Engine
This is Rietveld 408576698