Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2054)

Unified Diff: chrome/browser/page_load_metrics/metrics_web_contents_observer.cc

Issue 2386143003: Make PageLoadMetricsObserver::OnStart return ObservePolicy (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/page_load_metrics/metrics_web_contents_observer_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/page_load_metrics/metrics_web_contents_observer.cc
diff --git a/chrome/browser/page_load_metrics/metrics_web_contents_observer.cc b/chrome/browser/page_load_metrics/metrics_web_contents_observer.cc
index 1ca66e37badf183e35d83311e16ae78205437a41..4b7cf31162801e0b353c4e2dcd647afe4309e655 100644
--- a/chrome/browser/page_load_metrics/metrics_web_contents_observer.cc
+++ b/chrome/browser/page_load_metrics/metrics_web_contents_observer.cc
@@ -325,10 +325,8 @@ PageLoadTracker::PageLoadTracker(
}
embedder_interface_->RegisterObservers(this);
- for (const auto& observer : observers_) {
- observer->OnStart(navigation_handle, currently_committed_url,
- started_in_foreground_);
- }
+ INVOKE_AND_PRUNE_OBSERVERS(observers_, OnStart, navigation_handle,
+ currently_committed_url, started_in_foreground_);
}
PageLoadTracker::~PageLoadTracker() {
« no previous file with comments | « no previous file | chrome/browser/page_load_metrics/metrics_web_contents_observer_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698