chrome/browser/page_load_metrics/observers/https_engagement_metrics/https_engagement_page_load_metrics_observer.cc - Issue 2386143003: Make PageLoadMetricsObserver::OnStart return ObservePolicy

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/page_load_metrics/observers/https_engagement_metrics/https_engagement_page_load_metrics_observer.cc

Issue 2386143003: Make PageLoadMetricsObserver::OnStart return ObservePolicy (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/page_load_metrics/observers/https_engagement_metrics/https_engagement_page_load_metrics_observer.h ('k') | chrome/browser/page_load_metrics/page_load_metrics_observer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/page_load_metrics/observers/https_engagement_metrics/https_engagement_page_load_metrics_observer.cc

diff --git a/chrome/browser/page_load_metrics/observers/https_engagement_metrics/https_engagement_page_load_metrics_observer.cc b/chrome/browser/page_load_metrics/observers/https_engagement_metrics/https_engagement_page_load_metrics_observer.cc

index f49f0c6d83ed9f69d499029973020dfafaab57a6..d9722f25ea73ae56f86e0b8cfe2e232007e0eac2 100644

--- a/chrome/browser/page_load_metrics/observers/https_engagement_metrics/https_engagement_page_load_metrics_observer.cc

+++ b/chrome/browser/page_load_metrics/observers/https_engagement_metrics/https_engagement_page_load_metrics_observer.cc

@@ -20,12 +20,14 @@ HttpsEngagementPageLoadMetricsObserver::HttpsEngagementPageLoadMetricsObserver(

HttpsEngagementServiceFactory::GetForBrowserContext(context);

}

-void HttpsEngagementPageLoadMetricsObserver::OnStart(

+page_load_metrics::PageLoadMetricsObserver::ObservePolicy

+HttpsEngagementPageLoadMetricsObserver::OnStart(

content::NavigationHandle* navigation_handle,

const GURL& currently_committed_url,

bool started_in_foreground) {

if (started_in_foreground)

OnShown();

+ return CONTINUE_OBSERVING;

}

void HttpsEngagementPageLoadMetricsObserver::OnHidden() {