Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Issue 23851016: Convert zoom callbacks to use CallbackRegistry (Closed)

Created:
7 years, 3 months ago by Cait (Slow)
Modified:
7 years, 2 months ago
Reviewers:
jam
CC:
chromium-reviews, joi+watch-content_chromium.org, tfarina, erikwright+watch_chromium.org, jam, darin-cc_chromium.org, awong
Visibility:
Public.

Description

Convert zoom callbacks to use CallbackRegistry BUG=268984 TEST=no functional change. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=226409

Patch Set 1 #

Patch Set 2 : nits #

Patch Set 3 : mac fix #

Patch Set 4 : Remove commented bits #

Patch Set 5 : Asan fix #

Patch Set 6 : Rebase #

Total comments: 1

Patch Set 7 : Rebase and rename #

Patch Set 8 : Pure merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -136 lines) Patch
M chrome/browser/profiles/off_the_record_profile_impl.h View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/profiles/off_the_record_profile_impl.cc View 1 2 3 4 5 6 7 3 chunks +4 lines, -7 lines 0 comments Download
M chrome/browser/profiles/off_the_record_profile_impl_unittest.cc View 2 chunks +7 lines, -11 lines 0 comments Download
M chrome/browser/profiles/profile_impl.h View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/profiles/profile_impl.cc View 1 2 3 4 5 6 7 3 chunks +3 lines, -7 lines 0 comments Download
M chrome/browser/ui/browser_browsertest.cc View 1 2 3 4 5 6 7 3 chunks +12 lines, -12 lines 0 comments Download
M chrome/browser/ui/cocoa/location_bar/zoom_decoration_browsertest.mm View 1 2 3 4 5 6 2 chunks +7 lines, -8 lines 0 comments Download
M chrome/browser/ui/cocoa/wrench_menu/wrench_menu_controller.mm View 2 chunks +6 lines, -8 lines 0 comments Download
M chrome/browser/ui/gtk/browser_toolbar_gtk.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/browser_toolbar_gtk.cc View 3 chunks +5 lines, -8 lines 0 comments Download
M chrome/browser/ui/gtk/location_bar_view_gtk_browsertest.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M chrome/browser/ui/toolbar/wrench_menu_model.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/toolbar/wrench_menu_model.cc View 1 2 3 4 5 6 7 2 chunks +5 lines, -10 lines 0 comments Download
M chrome/browser/ui/views/wrench_menu.cc View 1 2 3 4 5 6 7 4 chunks +6 lines, -19 lines 0 comments Download
M chrome/browser/ui/zoom/zoom_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/zoom/zoom_controller.cc View 2 chunks +5 lines, -10 lines 0 comments Download
M content/browser/host_zoom_map_impl.h View 1 2 3 4 5 6 2 chunks +3 lines, -4 lines 0 comments Download
M content/browser/host_zoom_map_impl.cc View 4 chunks +6 lines, -19 lines 0 comments Download
M content/public/browser/host_zoom_map.h View 1 2 3 4 5 6 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Cait (Slow)
jam@: PTAL -- thanks!
7 years, 3 months ago (2013-09-11 21:20:47 UTC) #1
jam
lgtm, CallbackRegistry is nice to use. Please don't convert any callers that have multiple (or ...
7 years, 3 months ago (2013-09-12 17:55:58 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/caitkp@chromium.org/23851016/50001
7 years, 2 months ago (2013-10-01 21:54:09 UTC) #3
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 2 months ago (2013-10-01 23:09:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/caitkp@chromium.org/23851016/50001
7 years, 2 months ago (2013-10-01 23:17:24 UTC) #5
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 2 months ago (2013-10-01 23:48:59 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/caitkp@chromium.org/23851016/50001
7 years, 2 months ago (2013-10-02 03:23:39 UTC) #7
commit-bot: I haz the power
7 years, 2 months ago (2013-10-02 07:06:06 UTC) #8
Message was sent while issue was closed.
Change committed as 226409

Powered by Google App Engine
This is Rietveld 408576698