Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9040)

Unified Diff: chrome/browser/ui/toolbar/wrench_menu_model.cc

Issue 23851016: Convert zoom callbacks to use CallbackRegistry (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Pure merge Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/toolbar/wrench_menu_model.h ('k') | chrome/browser/ui/views/wrench_menu.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/toolbar/wrench_menu_model.cc
diff --git a/chrome/browser/ui/toolbar/wrench_menu_model.cc b/chrome/browser/ui/toolbar/wrench_menu_model.cc
index ec896c0d3b08f82d5b01cf5e47e98b3313ca3636..00a049c39b44809605378db1220feddbde095433 100644
--- a/chrome/browser/ui/toolbar/wrench_menu_model.cc
+++ b/chrome/browser/ui/toolbar/wrench_menu_model.cc
@@ -233,14 +233,14 @@ WrenchMenuModel::WrenchMenuModel(ui::AcceleratorProvider* provider,
: ui::SimpleMenuModel(this),
provider_(provider),
browser_(browser),
- tab_strip_model_(browser_->tab_strip_model()),
- zoom_callback_(base::Bind(&WrenchMenuModel::OnZoomLevelChanged,
- base::Unretained(this))) {
+ tab_strip_model_(browser_->tab_strip_model()) {
Build(is_new_menu);
UpdateZoomControls();
- HostZoomMap::GetForBrowserContext(
- browser->profile())->AddZoomLevelChangedCallback(zoom_callback_);
+ zoom_subscription_ = HostZoomMap::GetForBrowserContext(
+ browser->profile())->AddZoomLevelChangedCallback(
+ base::Bind(&WrenchMenuModel::OnZoomLevelChanged,
+ base::Unretained(this)));
tab_strip_model_->AddObserver(this);
@@ -251,11 +251,6 @@ WrenchMenuModel::WrenchMenuModel(ui::AcceleratorProvider* provider,
WrenchMenuModel::~WrenchMenuModel() {
if (tab_strip_model_)
tab_strip_model_->RemoveObserver(this);
-
- if (browser()) {
- HostZoomMap::GetForBrowserContext(
- browser()->profile())->RemoveZoomLevelChangedCallback(zoom_callback_);
- }
}
bool WrenchMenuModel::DoesCommandIdDismissMenu(int command_id) const {
« no previous file with comments | « chrome/browser/ui/toolbar/wrench_menu_model.h ('k') | chrome/browser/ui/views/wrench_menu.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698