Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1029)

Unified Diff: chrome/browser/ui/browser_browsertest.cc

Issue 23851016: Convert zoom callbacks to use CallbackRegistry (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Pure merge Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/browser_browsertest.cc
diff --git a/chrome/browser/ui/browser_browsertest.cc b/chrome/browser/ui/browser_browsertest.cc
index df5826073b2730ef0f1e6d7712ddb83688b814ed..8aebdc82cad128824e9b67c313294536f69554cf 100644
--- a/chrome/browser/ui/browser_browsertest.cc
+++ b/chrome/browser/ui/browser_browsertest.cc
@@ -1589,12 +1589,12 @@ IN_PROC_BROWSER_TEST_F(BrowserTest, MAYBE_PageZoom) {
new content::MessageLoopRunner);
content::HostZoomMap::ZoomLevelChangedCallback callback(
base::Bind(&OnZoomLevelChanged, loop_runner->QuitClosure()));
- content::HostZoomMap::GetForBrowserContext(
- browser()->profile())->AddZoomLevelChangedCallback(callback);
+ scoped_ptr<content::HostZoomMap::Subscription> sub =
+ content::HostZoomMap::GetForBrowserContext(
+ browser()->profile())->AddZoomLevelChangedCallback(callback);
chrome::Zoom(browser(), content::PAGE_ZOOM_IN);
loop_runner->Run();
- content::HostZoomMap::GetForBrowserContext(
- browser()->profile())->RemoveZoomLevelChangedCallback(callback);
+ sub.reset();
EXPECT_EQ(contents->GetZoomPercent(&enable_plus, &enable_minus), 110);
EXPECT_TRUE(enable_plus);
EXPECT_TRUE(enable_minus);
@@ -1605,12 +1605,12 @@ IN_PROC_BROWSER_TEST_F(BrowserTest, MAYBE_PageZoom) {
new content::MessageLoopRunner);
content::HostZoomMap::ZoomLevelChangedCallback callback(
base::Bind(&OnZoomLevelChanged, loop_runner->QuitClosure()));
- content::HostZoomMap::GetForBrowserContext(
- browser()->profile())->AddZoomLevelChangedCallback(callback);
+ scoped_ptr<content::HostZoomMap::Subscription> sub =
+ content::HostZoomMap::GetForBrowserContext(
+ browser()->profile())->AddZoomLevelChangedCallback(callback);
chrome::Zoom(browser(), content::PAGE_ZOOM_RESET);
loop_runner->Run();
- content::HostZoomMap::GetForBrowserContext(
- browser()->profile())->RemoveZoomLevelChangedCallback(callback);
+ sub.reset();
EXPECT_EQ(contents->GetZoomPercent(&enable_plus, &enable_minus), 100);
EXPECT_TRUE(enable_plus);
EXPECT_TRUE(enable_minus);
@@ -1621,12 +1621,12 @@ IN_PROC_BROWSER_TEST_F(BrowserTest, MAYBE_PageZoom) {
new content::MessageLoopRunner);
content::HostZoomMap::ZoomLevelChangedCallback callback(
base::Bind(&OnZoomLevelChanged, loop_runner->QuitClosure()));
- content::HostZoomMap::GetForBrowserContext(
- browser()->profile())->AddZoomLevelChangedCallback(callback);
+ scoped_ptr<content::HostZoomMap::Subscription> sub =
+ content::HostZoomMap::GetForBrowserContext(
+ browser()->profile())->AddZoomLevelChangedCallback(callback);
chrome::Zoom(browser(), content::PAGE_ZOOM_OUT);
loop_runner->Run();
- content::HostZoomMap::GetForBrowserContext(
- browser()->profile())->RemoveZoomLevelChangedCallback(callback);
+ sub.reset();
EXPECT_EQ(contents->GetZoomPercent(&enable_plus, &enable_minus), 90);
EXPECT_TRUE(enable_plus);
EXPECT_TRUE(enable_minus);
« no previous file with comments | « chrome/browser/profiles/profile_impl.cc ('k') | chrome/browser/ui/cocoa/location_bar/zoom_decoration_browsertest.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698