Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(654)

Unified Diff: content/browser/host_zoom_map_impl.cc

Issue 23851016: Convert zoom callbacks to use CallbackRegistry (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Pure merge Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/host_zoom_map_impl.h ('k') | content/public/browser/host_zoom_map.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/host_zoom_map_impl.cc
diff --git a/content/browser/host_zoom_map_impl.cc b/content/browser/host_zoom_map_impl.cc
index 667db376efd412472af76fc97110964ea8031fc4..e4058c2e6131a00349be4330e9296dbe8069e586 100644
--- a/content/browser/host_zoom_map_impl.cc
+++ b/content/browser/host_zoom_map_impl.cc
@@ -112,8 +112,7 @@ void HostZoomMapImpl::SetZoomLevelForHost(const std::string& host,
change.host = host;
change.zoom_level = level;
- for (size_t i = 0; i < zoom_level_changed_callbacks_.size(); i++)
- zoom_level_changed_callbacks_[i].Run(change);
+ zoom_level_changed_callbacks_.Notify(change);
}
void HostZoomMapImpl::SetZoomLevelForHostAndScheme(const std::string& scheme,
@@ -142,8 +141,7 @@ void HostZoomMapImpl::SetZoomLevelForHostAndScheme(const std::string& scheme,
change.scheme = scheme;
change.zoom_level = level;
- for (size_t i = 0; i < zoom_level_changed_callbacks_.size(); i++)
- zoom_level_changed_callbacks_[i].Run(change);
+ zoom_level_changed_callbacks_.Notify(change);
}
double HostZoomMapImpl::GetDefaultZoomLevel() const {
@@ -154,20 +152,10 @@ void HostZoomMapImpl::SetDefaultZoomLevel(double level) {
default_zoom_level_ = level;
}
-void HostZoomMapImpl::AddZoomLevelChangedCallback(
+scoped_ptr<HostZoomMap::Subscription>
+HostZoomMapImpl::AddZoomLevelChangedCallback(
const ZoomLevelChangedCallback& callback) {
- zoom_level_changed_callbacks_.push_back(callback);
-}
-
-void HostZoomMapImpl::RemoveZoomLevelChangedCallback(
- const ZoomLevelChangedCallback& callback) {
- for (size_t i = 0; i < zoom_level_changed_callbacks_.size(); i++) {
- if (zoom_level_changed_callbacks_[i].Equals(callback)) {
- zoom_level_changed_callbacks_.erase(
- zoom_level_changed_callbacks_.begin() + i);
- return;
- }
- }
+ return zoom_level_changed_callbacks_.Add(callback);
}
double HostZoomMapImpl::GetTemporaryZoomLevel(int render_process_id,
@@ -215,8 +203,7 @@ void HostZoomMapImpl::SetTemporaryZoomLevel(int render_process_id,
change.mode = HostZoomMap::ZOOM_CHANGED_TEMPORARY_ZOOM;
change.zoom_level = level;
- for (size_t i = 0; i < zoom_level_changed_callbacks_.size(); i++)
- zoom_level_changed_callbacks_[i].Run(change);
+ zoom_level_changed_callbacks_.Notify(change);
}
void HostZoomMapImpl::Observe(int type,
« no previous file with comments | « content/browser/host_zoom_map_impl.h ('k') | content/public/browser/host_zoom_map.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698