Android: Avoid linking with --gc-sections.

Android: Avoid linking with --gc-sections.

No more --gc-sections in debug mode for test targets either.

Re-enable instrumentation of globals in ASAN builds.

This is effectively a reland of r387491.

BUG=159801, 159847
Committed: https://crrev.com/404b02529e8f0139fa719f34ffa326014096a7c7
Cr-Commit-Position: refs/heads/master@{#422638}

[Lei Zhang, 2016-10-01 08:30:56]

The CQ bit was checked by thestig@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-01 08:31:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-01 09:46:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-01 09:46:41]

Dry run: This issue passed the CQ dry run.

[Lei Zhang, 2016-10-03 16:10:30]

thestig@chromium.org changed reviewers:
+ agrieve@chromium.org, eugenis@chromium.org

[Lei Zhang, 2016-10-03 16:10:30]

Trying again. I can no longer reproduce the error that caused
https://codereview.chromium.org/1883723004 to revert because the "Android Debug
(Nexus 9)" gpu.fyi bot no longer exists and the "Android Release (Nexus 9)"
gpu.fyi bot config builds fine locally.

[agrieve, 2016-10-03 18:34:17]

lgtm. Just one question. Thanks for tackling this!

https://codereview.chromium.org/2384953003/diff/1/build/config/compiler/BUILD.gn
File build/config/compiler/BUILD.gn (left):

https://codereview.chromium.org/2384953003/diff/1/build/config/compiler/BUILD...
build/config/compiler/BUILD.gn:1371: "-fdata-sections",
Would it make sense to also remove -fdata-sections and -ffunction-sections? I
think these are used only to make --gc-sections work.

[eugenis, 2016-10-03 20:07:39]

Looks great. Thanks!

[Lei Zhang, 2016-10-03 20:45:50]

https://codereview.chromium.org/2384953003/diff/1/build/config/compiler/BUILD.gn
File build/config/compiler/BUILD.gn (left):

https://codereview.chromium.org/2384953003/diff/1/build/config/compiler/BUILD...
build/config/compiler/BUILD.gn:1371: "-fdata-sections",
On 2016/10/03 18:34:17, agrieve wrote:
> Would it make sense to also remove -fdata-sections and -ffunction-sections? I
> think these are used only to make --gc-sections work.

Done.

[Lei Zhang, 2016-10-03 20:45:56]

The CQ bit was checked by thestig@chromium.org

[Lei Zhang, 2016-10-03 20:45:57]

The patchset sent to the CQ was uploaded after l-g-t-m from agrieve@chromium.org
Link to the patchset: https://codereview.chromium.org/2384953003/#ps20001
(title: "rebase, no {fdata,ffunction}-sections")

[commit-bot: I haz the power, 2016-10-03 20:47:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-04 00:46:15]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-04 00:50:09]

Description was changed from

==========
Android: Avoid linking with --gc-sections.

No more --gc-sections in debug mode for test targets either.

Re-enable instrumentation of globals in ASAN builds.

This is effectively a reland of r387491.

BUG=159801, 159847
==========

to

==========
Android: Avoid linking with --gc-sections.

No more --gc-sections in debug mode for test targets either.

Re-enable instrumentation of globals in ASAN builds.

This is effectively a reland of r387491.

BUG=159801, 159847

Committed: https://crrev.com/404b02529e8f0139fa719f34ffa326014096a7c7
Cr-Commit-Position: refs/heads/master@{#422638}
==========

[commit-bot: I haz the power, 2016-10-04 00:50:11]

Patchset 2 (id:??) landed as
https://crrev.com/404b02529e8f0139fa719f34ffa326014096a7c7
Cr-Commit-Position: refs/heads/master@{#422638}