Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(441)

Unified Diff: chrome/browser/ui/BUILD.gn

Issue 2384953003: Android: Avoid linking with --gc-sections. (Closed)
Patch Set: rebase, no {fdata,ffunction}-sections Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/config/sanitizers/sanitizers.gni ('k') | chrome/test/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/BUILD.gn
diff --git a/chrome/browser/ui/BUILD.gn b/chrome/browser/ui/BUILD.gn
index 8da8158e9b0d47912cfb57c6ffe7b198971f88f1..c343ae288b1f5b2280640e97f50225e91d64274a 100644
--- a/chrome/browser/ui/BUILD.gn
+++ b/chrome/browser/ui/BUILD.gn
@@ -3358,16 +3358,9 @@ static_library("test_support") {
"cocoa/cocoa_test_helper.mm",
"cocoa/run_loop_testing.h",
"cocoa/run_loop_testing.mm",
- "exclusive_access/fullscreen_controller_state_test.cc",
- "exclusive_access/fullscreen_controller_state_test.h",
- "exclusive_access/fullscreen_controller_state_tests.h",
- "exclusive_access/fullscreen_controller_test.cc",
- "exclusive_access/fullscreen_controller_test.h",
"find_bar/find_bar_host_unittest_util.h",
"login/login_handler_test_utils.cc",
"login/login_handler_test_utils.h",
- "test/test_confirm_bubble_model.cc",
- "test/test_confirm_bubble_model.h",
"toolbar/test_toolbar_action_view_controller.cc",
"toolbar/test_toolbar_action_view_controller.h",
]
@@ -3409,24 +3402,21 @@ static_library("test_support") {
]
}
- if (is_android) {
- sources -= [
+ if (!is_android) {
+ sources += [
"exclusive_access/fullscreen_controller_state_test.cc",
"exclusive_access/fullscreen_controller_state_test.h",
"exclusive_access/fullscreen_controller_state_tests.h",
"exclusive_access/fullscreen_controller_test.cc",
"exclusive_access/fullscreen_controller_test.h",
- "test/test_confirm_bubble_model.cc",
- "test/test_confirm_bubble_model.h",
- ]
- } else {
- sources += [
"passwords/manage_passwords_ui_controller_mock.cc",
"passwords/manage_passwords_ui_controller_mock.h",
"passwords/password_dialog_controller_mock.cc",
"passwords/password_dialog_controller_mock.h",
"passwords/passwords_model_delegate_mock.cc",
"passwords/passwords_model_delegate_mock.h",
+ "test/test_confirm_bubble_model.cc",
+ "test/test_confirm_bubble_model.h",
]
deps += [ "//chrome/test:test_support_ui" ]
}
« no previous file with comments | « build/config/sanitizers/sanitizers.gni ('k') | chrome/test/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698