build/config/sanitizers/sanitizers.gni - Issue 2384953003: Android: Avoid linking with --gc-sections.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/config/sanitizers/sanitizers.gni

Issue 2384953003: Android: Avoid linking with --gc-sections. (Closed)

Patch Set: rebase, no {fdata,ffunction}-sections Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/config/sanitizers/sanitizers.gni

diff --git a/build/config/sanitizers/sanitizers.gni b/build/config/sanitizers/sanitizers.gni

index 132512d2529c50cd90ba692f3265dd8a79fe22ca..8b933fd38eeb7a880d578407f0f89b1d2562d3df 100644

--- a/build/config/sanitizers/sanitizers.gni

+++ b/build/config/sanitizers/sanitizers.gni

@@ -134,13 +134,8 @@ declare_args() {

# Detect overflow/underflow for global objects.

- # Android build relies on -Wl,--gc-sections removing unreachable code.

- # ASan instrumentation for globals inhibits this and results in a

- # library with unresolvable relocations.

- # TODO(eugenis): find a way to reenable this.

- #

# Mac: http://crbug.com/352073

- asan_globals = !is_android && !is_mac

+ asan_globals = !is_mac

}

if (use_afl && sanitizer_coverage_flags == "") {

« no previous file with comments | « build/config/compiler/BUILD.gn ('k') | chrome/browser/ui/BUILD.gn » ('j') | no next file with comments »