Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2310)

Unified Diff: build/config/compiler/BUILD.gn

Issue 2384953003: Android: Avoid linking with --gc-sections. (Closed)
Patch Set: rebase, no {fdata,ffunction}-sections Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | build/config/sanitizers/sanitizers.gni » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/compiler/BUILD.gn
diff --git a/build/config/compiler/BUILD.gn b/build/config/compiler/BUILD.gn
index 738a907031ceae6156350e0f3f3e9bf50a1390f8..db0e6f0ef30569d62d0759b1f6f80af5a22f36e0 100644
--- a/build/config/compiler/BUILD.gn
+++ b/build/config/compiler/BUILD.gn
@@ -1372,15 +1372,7 @@ config("no_optimize") {
} else if (is_android && !android_full_debug) {
# On Android we kind of optimize some things that don't affect debugging
# much even when optimization is disabled to get the binary size down.
- cflags = [
- "-Os",
- "-fdata-sections",
- "-ffunction-sections",
- ]
-
- # Don't use gc-sections since it can cause links to succeed when they
- # actually shouldn't. http://crbug.com/159847
- ldflags = common_optimize_on_ldflags - [ "-Wl,--gc-sections" ]
+ cflags = [ "-Os" ]
} else {
cflags = [ "-O0" ]
ldflags = []
« no previous file with comments | « no previous file | build/config/sanitizers/sanitizers.gni » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698