Issue 23838002: [NaCl SDK] Simplify graphics3d example.

Issue 23838002: [NaCl SDK] Simplify graphics3d example. (Closed)

Created:
7 years, 3 months ago by binji

Modified:
7 years, 3 months ago

Reviewers:
noelallen1, Sam Clegg

CC:
chromium-reviews, Sam Clegg

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[NaCl SDK] Simplify graphics3d example. * Rewrote in ppapi_cpp * Remove URL loading (data is static in the .nexe) * Cube data is no longer generated * Added sliders for cube rotation (useful for testing) BUG=none R=noelallen@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221218

Patch Set 1 #

Patch Set 2 : remove test_projects change from CL #

Patch Set 3 : add stddef.h for offsetof #

Total comments: 2

Patch Set 4 : nits #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+572 lines, -579 lines)			Patch
M	native_client_sdk/src/examples/api/graphics_3d/example.dsc	View		1 chunk	+7 lines, -8 lines	0 comments	Download
A	native_client_sdk/src/examples/api/graphics_3d/example.js	View		1 chunk	+41 lines, -0 lines	0 comments	Download
D	native_client_sdk/src/examples/api/graphics_3d/fragment_shader_es2.frag	View		1 chunk	+0 lines, -8 lines	0 comments	Download
M	native_client_sdk/src/examples/api/graphics_3d/graphics_3d.cc	View	1 2 3	1 chunk	+435 lines, -549 lines	0 comments	Download
M	native_client_sdk/src/examples/api/graphics_3d/index.html	View		1 chunk	+25 lines, -2 lines	0 comments	Download
A	native_client_sdk/src/examples/api/graphics_3d/texture.cc	View		1 chunk	+64 lines, -0 lines	0 comments	Download
D	native_client_sdk/src/examples/api/graphics_3d/vertex_shader_es2.vert	View		1 chunk	+0 lines, -12 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

noelallen1

lgtm https://codereview.chromium.org/23838002/diff/8001/native_client_sdk/src/examples/api/graphics_3d/graphics_3d.cc File native_client_sdk/src/examples/api/graphics_3d/graphics_3d.cc (right): https://codereview.chromium.org/23838002/diff/8001/native_client_sdk/src/examples/api/graphics_3d/graphics_3d.cc#newcode118 native_client_sdk/src/examples/api/graphics_3d/graphics_3d.cc:118: glGetShaderInfoLog(shader, 1024, &length, &buffer[0]); 1024 vs sizeof(buffer)? https://codereview.chromium.org/23838002/diff/8001/native_client_sdk/src/examples/api/graphics_3d/graphics_3d.cc#newcode138 ...

7 years, 3 months ago (2013-09-03 20:55:25 UTC) #3

binji

7 years, 3 months ago (2013-09-04 17:19:39 UTC) #4

Message was sent while issue was closed.

Committed patchset #4 manually as r221218 (presubmit successful).

Expand Messages | Collapse Messages