Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2383573002: [DO NOT COMMIT] Remove chrome::NOTIFICATION_RETARGETING

Created:
4 years, 2 months ago by nasko
Modified:
4 years, 2 months ago
Reviewers:
CC:
chromium-reviews, extensions-reviews_chromium.org, creis+watch_chromium.org, mlamouri+watch-content_chromium.org, nasko+codewatch_chromium.org, jam, darin-cc_chromium.org, chromium-apps-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DO NOT COMMIT] Remove chrome::NOTIFICATION_RETARGETING BUG=649855 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Remove notification from RequestOpenURL and add WCOSanityChecker support. #

Patch Set 4 : Add stack tracing to WCOSanityChecker. #

Patch Set 5 : Remove CreateNewWindow notification. #

Patch Set 6 : Rebase on ToT. #

Patch Set 7 : Test #

Patch Set 8 : Undo chrome::Navigate changes #

Patch Set 9 : Rebase on ToT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+206 lines, -39 lines) Patch
M chrome/browser/extensions/api/web_navigation/web_navigation_api.h View 1 2 3 4 5 4 chunks +6 lines, -7 lines 0 comments Download
M chrome/browser/extensions/api/web_navigation/web_navigation_api.cc View 1 2 3 4 5 6 11 chunks +44 lines, -11 lines 0 comments Download
M chrome/browser/renderer_context_menu/render_view_context_menu.cc View 1 2 3 4 5 6 7 8 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/browser.cc View 1 2 3 4 5 6 7 8 3 chunks +9 lines, -0 lines 0 comments Download
M chrome/browser/ui/browser_navigator.cc View 1 2 3 4 5 6 7 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/test/data/extensions/api_test/webnavigation/userAction/framework.js View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/webnavigation/userAction/test_userAction.js View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M components/renderer_context_menu/render_view_context_menu_base.cc View 1 2 3 4 5 6 7 8 2 chunks +4 lines, -2 lines 0 comments Download
M content/browser/frame_host/render_frame_host_impl.cc View 1 2 3 4 5 6 7 8 11 chunks +34 lines, -0 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 1 2 3 4 5 6 7 8 4 chunks +32 lines, -15 lines 0 comments Download
M content/public/browser/web_contents.h View 1 2 3 4 5 6 7 1 chunk +12 lines, -0 lines 0 comments Download
M content/public/browser/web_contents.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 1 2 3 4 5 6 7 8 9 chunks +25 lines, -0 lines 0 comments Download
M content/renderer/render_frame_proxy.cc View 1 2 3 4 5 6 7 4 chunks +7 lines, -0 lines 0 comments Download
M content/test/web_contents_observer_sanity_checker.h View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M content/test/web_contents_observer_sanity_checker.cc View 1 2 3 3 chunks +15 lines, -0 lines 0 comments Download

Messages

Total messages: 33 (33 generated)
nasko
Description was changed from ========== [DO NOT COMMIT] Remove chrome::NOTIFICATION_RETARGETING BUG=649855 ========== to ========== [DO ...
4 years, 2 months ago (2016-09-29 17:34:52 UTC) #1
nasko
The CQ bit was checked by nasko@chromium.org to run a CQ dry run
4 years, 2 months ago (2016-09-29 17:39:31 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2383573002/1
4 years, 2 months ago (2016-09-29 17:39:52 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 2 months ago (2016-09-29 17:43:34 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm64_dbg_recipe/builds/136809) linux_android_rel_ng on ...
4 years, 2 months ago (2016-09-29 17:43:35 UTC) #5
nasko
The CQ bit was checked by nasko@chromium.org to run a CQ dry run
4 years, 2 months ago (2016-09-29 18:07:34 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2383573002/20001
4 years, 2 months ago (2016-09-29 18:07:55 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 2 months ago (2016-09-29 19:03:21 UTC) #8
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/234733)
4 years, 2 months ago (2016-09-29 19:03:22 UTC) #9
nasko
The CQ bit was checked by nasko@chromium.org to run a CQ dry run
4 years, 2 months ago (2016-09-30 17:15:18 UTC) #10
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2383573002/40001
4 years, 2 months ago (2016-09-30 17:15:54 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 2 months ago (2016-09-30 18:10:00 UTC) #12
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/235467)
4 years, 2 months ago (2016-09-30 18:10:01 UTC) #13
nasko
The CQ bit was checked by nasko@chromium.org to run a CQ dry run
4 years, 2 months ago (2016-09-30 21:00:32 UTC) #14
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2383573002/60001
4 years, 2 months ago (2016-09-30 21:01:04 UTC) #15
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 2 months ago (2016-09-30 21:12:26 UTC) #16
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/271028)
4 years, 2 months ago (2016-09-30 21:12:27 UTC) #17
nasko
The CQ bit was checked by nasko@chromium.org to run a CQ dry run
4 years, 2 months ago (2016-10-03 15:57:34 UTC) #18
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2383573002/80001
4 years, 2 months ago (2016-10-03 15:57:52 UTC) #19
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 2 months ago (2016-10-03 16:06:20 UTC) #20
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/271937)
4 years, 2 months ago (2016-10-03 16:06:21 UTC) #21
nasko
The CQ bit was checked by nasko@chromium.org to run a CQ dry run
4 years, 2 months ago (2016-10-14 23:31:19 UTC) #22
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2383573002/120001
4 years, 2 months ago (2016-10-14 23:31:44 UTC) #23
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 2 months ago (2016-10-14 23:41:55 UTC) #24
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/281854)
4 years, 2 months ago (2016-10-14 23:41:56 UTC) #25
nasko
The CQ bit was checked by nasko@chromium.org to run a CQ dry run
4 years, 2 months ago (2016-10-19 13:49:39 UTC) #26
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2383573002/140001
4 years, 2 months ago (2016-10-19 13:50:01 UTC) #27
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 2 months ago (2016-10-19 13:52:18 UTC) #28
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/289817) mac_chromium_rel_ng on ...
4 years, 2 months ago (2016-10-19 13:52:19 UTC) #29
nasko
The CQ bit was checked by nasko@chromium.org to run a CQ dry run
4 years, 2 months ago (2016-10-19 14:13:54 UTC) #30
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2383573002/160001
4 years, 2 months ago (2016-10-19 14:14:14 UTC) #31
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 2 months ago (2016-10-19 14:29:45 UTC) #32
commit-bot: I haz the power
4 years, 2 months ago (2016-10-19 14:29:45 UTC) #33 
Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

Powered by Google App Engine
This is Rietveld 408576698