Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6509)

Unified Diff: chrome/browser/ui/browser.cc

Issue 2383573002: [DO NOT COMMIT] Remove chrome::NOTIFICATION_RETARGETING
Patch Set: Rebase on ToT Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/browser.cc
diff --git a/chrome/browser/ui/browser.cc b/chrome/browser/ui/browser.cc
index 4c02948d4ae9543a60c89f9fa0b97db30fb0ee48..c34b8dd805bb1aa34641187f0b30c27150902a9c 100644
--- a/chrome/browser/ui/browser.cc
+++ b/chrome/browser/ui/browser.cc
@@ -1605,6 +1605,12 @@ void Browser::WebContentsCreated(WebContents* source_contents,
const std::string& frame_name,
const GURL& target_url,
WebContents* new_contents) {
+ LOG(ERROR) << "Browser::WebContentsCreated: "
+ << " source_contents:" << source_contents
+ << " opener_frame:" << opener_render_frame_id
+ << " target_url:" << target_url
+ << " new contents:" << new_contents;
+
// Adopt the WebContents now, so all observers are in place, as the network
// requests for its initial navigation will start immediately. The WebContents
// will later be inserted into this browser using Browser::Navigate via
@@ -1614,6 +1620,7 @@ void Browser::WebContentsCreated(WebContents* source_contents,
// Make the tab show up in the task manager.
task_manager::WebContentsTags::CreateForTabContents(new_contents);
+ /*
// Notify.
RetargetingDetails details;
details.source_web_contents = source_contents;
@@ -1622,10 +1629,12 @@ void Browser::WebContentsCreated(WebContents* source_contents,
details.target_url = target_url;
details.target_web_contents = new_contents;
details.not_yet_in_tabstrip = true;
+ LOG(ERROR) << "Browser::WebContentsCreated: dispatch RETARGETING";
content::NotificationService::current()->Notify(
chrome::NOTIFICATION_RETARGETING,
content::Source<Profile>(profile_),
content::Details<RetargetingDetails>(&details));
+ */
}
void Browser::RendererUnresponsive(
« no previous file with comments | « chrome/browser/renderer_context_menu/render_view_context_menu.cc ('k') | chrome/browser/ui/browser_navigator.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698