Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Unified Diff: chrome/browser/extensions/api/web_navigation/web_navigation_api.h

Issue 2383573002: [DO NOT COMMIT] Remove chrome::NOTIFICATION_RETARGETING
Patch Set: Rebase on ToT Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/extensions/api/web_navigation/web_navigation_api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/api/web_navigation/web_navigation_api.h
diff --git a/chrome/browser/extensions/api/web_navigation/web_navigation_api.h b/chrome/browser/extensions/api/web_navigation/web_navigation_api.h
index 47a2915470d4df2f34b45667434d48565723c80e..6cc799802381a4d547090c7fd44b8c4efaeece09 100644
--- a/chrome/browser/extensions/api/web_navigation/web_navigation_api.h
+++ b/chrome/browser/extensions/api/web_navigation/web_navigation_api.h
@@ -110,7 +110,11 @@ class WebNavigationEventRouter : public TabStripModelObserver,
explicit WebNavigationEventRouter(Profile* profile);
~WebNavigationEventRouter() override;
- private:
+ // Handler for the NOTIFICATION_RETARGETING event. The method takes the
+ // details of such an event and stores them for the later
+ // NOTIFICATION_TAB_ADDED event.
+ void Retargeting(const RetargetingDetails* details);
+
// Used to cache the information about newly created WebContents objects.
struct PendingWebContents{
PendingWebContents();
@@ -126,6 +130,7 @@ class WebNavigationEventRouter : public TabStripModelObserver,
GURL target_url;
};
+ private:
// BrowserTabStripTrackerDelegate implementation.
bool ShouldTrackBrowser(Browser* browser) override;
@@ -140,11 +145,6 @@ class WebNavigationEventRouter : public TabStripModelObserver,
const content::NotificationSource& source,
const content::NotificationDetails& details) override;
- // Handler for the NOTIFICATION_RETARGETING event. The method takes the
- // details of such an event and stores them for the later
- // NOTIFICATION_TAB_ADDED event.
- void Retargeting(const RetargetingDetails* details);
-
// Handler for the NOTIFICATION_TAB_ADDED event. The method takes the details
// of such an event and creates a JSON formated extension event from it.
void TabAdded(content::WebContents* tab);
@@ -155,7 +155,6 @@ class WebNavigationEventRouter : public TabStripModelObserver,
// Mapping pointers to WebContents objects to information about how they got
// created.
- std::map<content::WebContents*, PendingWebContents> pending_web_contents_;
// Used for tracking registrations to navigation notifications.
content::NotificationRegistrar registrar_;
« no previous file with comments | « no previous file | chrome/browser/extensions/api/web_navigation/web_navigation_api.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698