Cleanup histograms from message loop, as well as kHexRangePrintingFlag.

Cleanup histograms from message loop, as well as kHexRangePrintingFlag.

The message loop histograms are only accessible via command line so are not really that useful. We have similar data via profiler and traces. Note that this logic is very old, added by jar@ from the historical repo.

Removed support for HistogramBase::kHexRangePrintingFlag, which was an available flag for creating histograms. The intention was to make chrome://histograms more readable, but was never really used.

Other minor changes:
 - visual change to chrome://histograms (average -> mean).
 -  made the flag comment a bit more friendly as part of the "make chrome reviews friendlier" effort :)
BUG=651169
Committed: https://crrev.com/035eb12a2d163d3d3c9185f800acd3d800d56444
Cr-Commit-Position: refs/heads/master@{#421650}

[rkaplow, 2016-09-28 19:17:48]

Description was changed from

==========
Cleanup histograms from message loop, as well as kHexRangePrintingFlag.

The message loop histograms are only accessible via command line so are not
really that useful. We have similar data via profiler and traces. Note that this
logic is very old, added by jar@ from the historical repo.

I also cleaned up the a histogram flag that was used here, as well as making a
minor visual change to chrome://histograms (average -> mean).

BUG=651169
==========

to

==========
Cleanup histograms from message loop, as well as kHexRangePrintingFlag.

The message loop histograms are only accessible via command line so are not
really that useful. We have similar data via profiler and traces. Note that this
logic is very old, added by jar@ from the historical repo.

I also cleaned up the a histogram flag that was used here, as well as making a
minor visual change to chrome://histograms (average -> mean).

BUG=651169
==========

[rkaplow, 2016-09-28 19:17:48]

rkaplow@chromium.org changed reviewers:
+ asvitkine@chromium.org, thestig@chromium.org

[Lei Zhang, 2016-09-28 19:25:27]

lgtm if asvitkine approves.

[Alexei Svitkine (slow), 2016-09-28 19:27:48]

LGTM+++!! Would LGTM again!

Maybe make the description explicit about what support from base/metrics
histogram classes is being removed at the same time in the CL description.

https://codereview.chromium.org/2382503002/diff/1/base/message_loop/message_l...
File base/message_loop/message_loop.cc (right):

https://codereview.chromium.org/2382503002/diff/1/base/message_loop/message_l...
base/message_loop/message_loop.cc:485: 
Nit: Remove extra line.

[rkaplow, 2016-09-28 19:39:12]

Description was changed from

==========
Cleanup histograms from message loop, as well as kHexRangePrintingFlag.

The message loop histograms are only accessible via command line so are not
really that useful. We have similar data via profiler and traces. Note that this
logic is very old, added by jar@ from the historical repo.

I also cleaned up the a histogram flag that was used here, as well as making a
minor visual change to chrome://histograms (average -> mean).

BUG=651169
==========

to

==========
Cleanup histograms from message loop, as well as kHexRangePrintingFlag.

The message loop histograms are only accessible via command line so are not
really that useful. We have similar data via profiler and traces. Note that this
logic is very old, added by jar@ from the historical repo.

Removed support for HistogramBase::kHexRangePrintingFlag, which was an available
flag for creating histograms. The intention was to make chrome://histograms more
readable, but was never really used.

Other minor changes:
 - visual change to chrome://histograms (average -> mean).
 -  made the flag comment a bit more friendly as part of the "make chrome
reviews friendlier" effort :)
BUG=651169
==========

[rkaplow, 2016-09-28 19:40:37]

More details in description + changed the flag comment

https://codereview.chromium.org/2382503002/diff/1/base/message_loop/message_l...
File base/message_loop/message_loop.cc (right):

https://codereview.chromium.org/2382503002/diff/1/base/message_loop/message_l...
base/message_loop/message_loop.cc:485: 
On 2016/09/28 19:27:48, Alexei Svitkine (slow) wrote:
> Nit: Remove extra line.

Done.

[Alexei Svitkine (slow), 2016-09-28 19:54:28]

LGTM!

[rkaplow, 2016-09-28 19:59:16]

The CQ bit was checked by rkaplow@chromium.org

[rkaplow, 2016-09-28 19:59:17]

The patchset sent to the CQ was uploaded after l-g-t-m from thestig@chromium.org
Link to the patchset: https://codereview.chromium.org/2382503002/#ps40001
(title: "make flag comment nicer")

[commit-bot: I haz the power, 2016-09-28 19:59:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-28 21:48:54]

Description was changed from

==========
Cleanup histograms from message loop, as well as kHexRangePrintingFlag.

The message loop histograms are only accessible via command line so are not
really that useful. We have similar data via profiler and traces. Note that this
logic is very old, added by jar@ from the historical repo.

Removed support for HistogramBase::kHexRangePrintingFlag, which was an available
flag for creating histograms. The intention was to make chrome://histograms more
readable, but was never really used.

Other minor changes:
 - visual change to chrome://histograms (average -> mean).
 -  made the flag comment a bit more friendly as part of the "make chrome
reviews friendlier" effort :)
BUG=651169
==========

to

==========
Cleanup histograms from message loop, as well as kHexRangePrintingFlag.

The message loop histograms are only accessible via command line so are not
really that useful. We have similar data via profiler and traces. Note that this
logic is very old, added by jar@ from the historical repo.

Removed support for HistogramBase::kHexRangePrintingFlag, which was an available
flag for creating histograms. The intention was to make chrome://histograms more
readable, but was never really used.

Other minor changes:
 - visual change to chrome://histograms (average -> mean).
 -  made the flag comment a bit more friendly as part of the "make chrome
reviews friendlier" effort :)
BUG=651169
==========

[commit-bot: I haz the power, 2016-09-28 21:48:55]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-09-28 21:50:51]

Description was changed from

==========
Cleanup histograms from message loop, as well as kHexRangePrintingFlag.

The message loop histograms are only accessible via command line so are not
really that useful. We have similar data via profiler and traces. Note that this
logic is very old, added by jar@ from the historical repo.

Removed support for HistogramBase::kHexRangePrintingFlag, which was an available
flag for creating histograms. The intention was to make chrome://histograms more
readable, but was never really used.

Other minor changes:
 - visual change to chrome://histograms (average -> mean).
 -  made the flag comment a bit more friendly as part of the "make chrome
reviews friendlier" effort :)
BUG=651169
==========

to

==========
Cleanup histograms from message loop, as well as kHexRangePrintingFlag.

The message loop histograms are only accessible via command line so are not
really that useful. We have similar data via profiler and traces. Note that this
logic is very old, added by jar@ from the historical repo.

Removed support for HistogramBase::kHexRangePrintingFlag, which was an available
flag for creating histograms. The intention was to make chrome://histograms more
readable, but was never really used.

Other minor changes:
 - visual change to chrome://histograms (average -> mean).
 -  made the flag comment a bit more friendly as part of the "make chrome
reviews friendlier" effort :)
BUG=651169

Committed: https://crrev.com/035eb12a2d163d3d3c9185f800acd3d800d56444
Cr-Commit-Position: refs/heads/master@{#421650}
==========

[commit-bot: I haz the power, 2016-09-28 21:50:52]

Patchset 3 (id:??) landed as
https://crrev.com/035eb12a2d163d3d3c9185f800acd3d800d56444
Cr-Commit-Position: refs/heads/master@{#421650}