base/metrics/sparse_histogram.cc - Issue 2382503002: Cleanup histograms from message loop, as well as kHexRangePrintingFlag.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/metrics/sparse_histogram.cc

Issue 2382503002: Cleanup histograms from message loop, as well as kHexRangePrintingFlag. (Closed)

Patch Set: make flag comment nicer Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/metrics/sparse_histogram.cc

diff --git a/base/metrics/sparse_histogram.cc b/base/metrics/sparse_histogram.cc

index deba570059427d60493a24f3725657e13e259ce3..a8dfbeb757bcdb28d9b014436efe779bcdbc6be3 100644

--- a/base/metrics/sparse_histogram.cc

+++ b/base/metrics/sparse_histogram.cc

@@ -282,8 +282,8 @@ void SparseHistogram::WriteAsciiHeader(const Count total_count,

"Histogram: %s recorded %d samples",

histogram_name().c_str(),

total_count);

- if (flags() & ~kHexRangePrintingFlag)

- StringAppendF(output, " (flags = 0x%x)", flags() & ~kHexRangePrintingFlag);

+ if (flags())

+ StringAppendF(output, " (flags = 0x%x)", flags());

}

} // namespace base

« no previous file with comments | « base/metrics/histogram_base.cc ('k') | chrome/app/chrome_main_delegate.cc » ('j') | no next file with comments »