Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1786)

Side by Side Diff: base/metrics/histogram_base.h

Issue 2382503002: Cleanup histograms from message loop, as well as kHexRangePrintingFlag. (Closed)
Patch Set: make flag comment nicer Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « base/metrics/histogram.cc ('k') | base/metrics/histogram_base.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef BASE_METRICS_HISTOGRAM_BASE_H_ 5 #ifndef BASE_METRICS_HISTOGRAM_BASE_H_
6 #define BASE_METRICS_HISTOGRAM_BASE_H_ 6 #define BASE_METRICS_HISTOGRAM_BASE_H_
7 7
8 #include <limits.h> 8 #include <limits.h>
9 #include <stddef.h> 9 #include <stddef.h>
10 #include <stdint.h> 10 #include <stdint.h>
(...skipping 103 matching lines...) Expand 10 before | Expand all | Expand 10 after
114 // histograms can be in performance critical code, and this allows us 114 // histograms can be in performance critical code, and this allows us
115 // to shortcut looking up the callback if it doesn't exist. 115 // to shortcut looking up the callback if it doesn't exist.
116 kCallbackExists = 0x20, 116 kCallbackExists = 0x20,
117 117
118 // Indicates that the histogram is held in "persistent" memory and may 118 // Indicates that the histogram is held in "persistent" memory and may
119 // be accessible between processes. This is only possible if such a 119 // be accessible between processes. This is only possible if such a
120 // memory segment has been created/attached, used to create a Persistent- 120 // memory segment has been created/attached, used to create a Persistent-
121 // MemoryAllocator, and that loaded into the Histogram module before this 121 // MemoryAllocator, and that loaded into the Histogram module before this
122 // histogram is created. 122 // histogram is created.
123 kIsPersistent = 0x40, 123 kIsPersistent = 0x40,
124
125 // TODO(rkaplow): Look into this, but looks like this is unused and can
126 // be removed.
127 // Only for Histogram and its sub classes: fancy bucket-naming support.
128 kHexRangePrintingFlag = 0x8000,
129 }; 124 };
130 125
131 // Histogram data inconsistency types. 126 // Histogram data inconsistency types.
132 enum Inconsistency : uint32_t { 127 enum Inconsistency : uint32_t {
133 NO_INCONSISTENCIES = 0x0, 128 NO_INCONSISTENCIES = 0x0,
134 RANGE_CHECKSUM_ERROR = 0x1, 129 RANGE_CHECKSUM_ERROR = 0x1,
135 BUCKET_ORDER_ERROR = 0x2, 130 BUCKET_ORDER_ERROR = 0x2,
136 COUNT_HIGH_ERROR = 0x4, 131 COUNT_HIGH_ERROR = 0x4,
137 COUNT_LOW_ERROR = 0x8, 132 COUNT_LOW_ERROR = 0x8,
138 133
(...skipping 133 matching lines...) Expand 10 before | Expand all | Expand 10 after
272 267
273 const std::string histogram_name_; 268 const std::string histogram_name_;
274 AtomicCount flags_; 269 AtomicCount flags_;
275 270
276 DISALLOW_COPY_AND_ASSIGN(HistogramBase); 271 DISALLOW_COPY_AND_ASSIGN(HistogramBase);
277 }; 272 };
278 273
279 } // namespace base 274 } // namespace base
280 275
281 #endif // BASE_METRICS_HISTOGRAM_BASE_H_ 276 #endif // BASE_METRICS_HISTOGRAM_BASE_H_
OLDNEW
« no previous file with comments | « base/metrics/histogram.cc ('k') | base/metrics/histogram_base.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698