Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2656)

Unified Diff: base/metrics/histogram_base.cc

Issue 2382503002: Cleanup histograms from message loop, as well as kHexRangePrintingFlag. (Closed)
Patch Set: make flag comment nicer Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/metrics/histogram_base.h ('k') | base/metrics/sparse_histogram.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/metrics/histogram_base.cc
diff --git a/base/metrics/histogram_base.cc b/base/metrics/histogram_base.cc
index c2daf3cc55ac142dbf5095da29cfbc83544b658e..6dd91b25380ca440b0bce70a3b997cc8ff1fd834 100644
--- a/base/metrics/histogram_base.cc
+++ b/base/metrics/histogram_base.cc
@@ -173,12 +173,7 @@ void HistogramBase::WriteAsciiBucketGraph(double current_size,
const std::string HistogramBase::GetSimpleAsciiBucketRange(
Sample sample) const {
- std::string result;
- if (kHexRangePrintingFlag & flags())
- StringAppendF(&result, "%#x", sample);
- else
- StringAppendF(&result, "%d", sample);
- return result;
+ return StringPrintf("%d", sample);
}
void HistogramBase::WriteAsciiBucketValue(Count current,
« no previous file with comments | « base/metrics/histogram_base.h ('k') | base/metrics/sparse_histogram.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698