Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 2382113002: Use clearer names for the PictureBuffer texture id members (Closed)

Created:
4 years, 2 months ago by watk
Modified:
4 years, 1 month ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, posciak+watch_chromium.org, jam, feature-media-reviews_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use clearer names for the PictureBuffer texture id members s/texture_ids/client_texture_ids and s/internal_texture_ids/service_texture_ids/ because these names are clearer and more consistent with the rest of the gpu code. This also cleans up GpuVideoDecodeAccelerator and the VDAs, which used internal_texure_ids to refer to the client ids, and texture_ids to refer to the service ids. Committed: https://crrev.com/d3088b3826b4122fc534096da1f06b9383e9bdd2 Cr-Commit-Position: refs/heads/master@{#427237}

Patch Set 1 #

Patch Set 2 : Added comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+91 lines, -92 lines) Patch
M content/renderer/media/gpu/rtc_video_decoder.cc View 4 chunks +6 lines, -4 lines 0 comments Download
M content/renderer/pepper/video_decoder_shim.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M media/filters/gpu_video_decoder.cc View 5 chunks +24 lines, -27 lines 0 comments Download
M media/gpu/avda_picture_buffer_manager.cc View 1 2 chunks +4 lines, -4 lines 0 comments Download
M media/gpu/dxva_picture_buffer_win.cc View 3 chunks +9 lines, -9 lines 0 comments Download
M media/gpu/dxva_video_decode_accelerator_win.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M media/gpu/fake_video_decode_accelerator.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M media/gpu/ipc/client/gpu_video_decode_accelerator_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/gpu/ipc/service/gpu_video_decode_accelerator.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/gpu/v4l2_slice_video_decode_accelerator.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M media/gpu/v4l2_video_decode_accelerator.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M media/gpu/vaapi_video_decode_accelerator.cc View 1 chunk +7 lines, -6 lines 0 comments Download
M media/gpu/vt_video_decode_accelerator_mac.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M media/video/picture.h View 1 3 chunks +16 lines, -17 lines 0 comments Download
M media/video/picture.cc View 1 chunk +10 lines, -10 lines 0 comments Download

Messages

Total messages: 52 (37 generated)
watk
PTAL, thanks
4 years, 2 months ago (2016-09-30 22:31:39 UTC) #11
watk
ping
4 years, 2 months ago (2016-10-07 22:31:04 UTC) #18
watk
ping
4 years, 2 months ago (2016-10-11 19:18:02 UTC) #19
watk
+sandersd. PTAL
4 years, 2 months ago (2016-10-17 22:07:26 UTC) #21
sandersd (OOO until July 31)
lgtm
4 years, 2 months ago (2016-10-17 22:16:29 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2382113002/40001
4 years, 2 months ago (2016-10-17 22:20:48 UTC) #24
watk
bbudge@chromium.org: Please review changes in content/renderer/pepper
4 years, 2 months ago (2016-10-17 22:26:33 UTC) #33
bbudge
content/renderer/pepper lgtm
4 years, 2 months ago (2016-10-17 22:27:36 UTC) #35
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2382113002/40001
4 years, 2 months ago (2016-10-22 00:17:10 UTC) #39
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/321867)
4 years, 2 months ago (2016-10-22 03:21:46 UTC) #41
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2382113002/40001
4 years, 1 month ago (2016-10-24 20:09:15 UTC) #44
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm64_dbg_recipe/builds/151268)
4 years, 1 month ago (2016-10-25 00:19:40 UTC) #46
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2382113002/40001
4 years, 1 month ago (2016-10-25 00:22:28 UTC) #48
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 1 month ago (2016-10-25 02:03:16 UTC) #50
commit-bot: I haz the power
4 years, 1 month ago (2016-10-25 02:06:19 UTC) #52
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d3088b3826b4122fc534096da1f06b9383e9bdd2
Cr-Commit-Position: refs/heads/master@{#427237}

Powered by Google App Engine
This is Rietveld 408576698