Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Side by Side Diff: media/video/picture.cc

Issue 2382113002: Use clearer names for the PictureBuffer texture id members (Closed)
Patch Set: Added comments Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « media/video/picture.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/macros.h" 5 #include "base/macros.h"
6 #include "media/video/picture.h" 6 #include "media/video/picture.h"
7 7
8 namespace media { 8 namespace media {
9 9
10 PictureBuffer::PictureBuffer(int32_t id, 10 PictureBuffer::PictureBuffer(int32_t id,
11 gfx::Size size, 11 gfx::Size size,
12 const TextureIds& texture_ids) 12 const TextureIds& client_texture_ids)
13 : id_(id), size_(size), texture_ids_(texture_ids) {} 13 : id_(id), size_(size), client_texture_ids_(client_texture_ids) {}
14 14
15 PictureBuffer::PictureBuffer(int32_t id, 15 PictureBuffer::PictureBuffer(int32_t id,
16 gfx::Size size, 16 gfx::Size size,
17 const TextureIds& texture_ids, 17 const TextureIds& client_texture_ids,
18 const TextureIds& internal_texture_ids) 18 const TextureIds& service_texture_ids)
19 : id_(id), 19 : id_(id),
20 size_(size), 20 size_(size),
21 texture_ids_(texture_ids), 21 client_texture_ids_(client_texture_ids),
22 internal_texture_ids_(internal_texture_ids) { 22 service_texture_ids_(service_texture_ids) {
23 DCHECK_EQ(texture_ids.size(), internal_texture_ids.size()); 23 DCHECK_EQ(client_texture_ids.size(), service_texture_ids.size());
24 } 24 }
25 25
26 PictureBuffer::PictureBuffer(int32_t id, 26 PictureBuffer::PictureBuffer(int32_t id,
27 gfx::Size size, 27 gfx::Size size,
28 const TextureIds& texture_ids, 28 const TextureIds& client_texture_ids,
29 const std::vector<gpu::Mailbox>& texture_mailboxes) 29 const std::vector<gpu::Mailbox>& texture_mailboxes)
30 : id_(id), 30 : id_(id),
31 size_(size), 31 size_(size),
32 texture_ids_(texture_ids), 32 client_texture_ids_(client_texture_ids),
33 texture_mailboxes_(texture_mailboxes) { 33 texture_mailboxes_(texture_mailboxes) {
34 DCHECK_EQ(texture_ids.size(), texture_mailboxes.size()); 34 DCHECK_EQ(client_texture_ids.size(), texture_mailboxes.size());
35 } 35 }
36 36
37 PictureBuffer::PictureBuffer(const PictureBuffer& other) = default; 37 PictureBuffer::PictureBuffer(const PictureBuffer& other) = default;
38 38
39 PictureBuffer::~PictureBuffer() {} 39 PictureBuffer::~PictureBuffer() {}
40 40
41 Picture::Picture(int32_t picture_buffer_id, 41 Picture::Picture(int32_t picture_buffer_id,
42 int32_t bitstream_buffer_id, 42 int32_t bitstream_buffer_id,
43 const gfx::Rect& visible_rect, 43 const gfx::Rect& visible_rect,
44 bool allow_overlay) 44 bool allow_overlay)
45 : picture_buffer_id_(picture_buffer_id), 45 : picture_buffer_id_(picture_buffer_id),
46 bitstream_buffer_id_(bitstream_buffer_id), 46 bitstream_buffer_id_(bitstream_buffer_id),
47 visible_rect_(visible_rect), 47 visible_rect_(visible_rect),
48 allow_overlay_(allow_overlay), 48 allow_overlay_(allow_overlay),
49 size_changed_(false) {} 49 size_changed_(false) {}
50 50
51 } // namespace media 51 } // namespace media
OLDNEW
« no previous file with comments | « media/video/picture.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698