Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1017)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2381793003: Rename Universe to WorldBuilder. (Closed)

Created:
4 years, 2 months ago by Johnni Winther
Modified:
4 years, 2 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 7
Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -706 lines) Patch
M pkg/compiler/lib/src/closure.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/compiler.dart View 2 chunks +4 lines, -3 lines 2 comments Download
M pkg/compiler/lib/src/dump_info.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/enqueue.dart View 4 chunks +5 lines, -5 lines 2 comments Download
M pkg/compiler/lib/src/js_backend/backend.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_backend/enqueuer.dart View 3 chunks +4 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/js_interop_analysis.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_backend/runtime_types.dart View 3 chunks +4 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/js_emitter.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_emitter/program_builder/program_builder.dart View 3 chunks +5 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/types/masks.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/universe/function_set.dart View 1 chunk +1 line, -1 line 0 comments Download
D pkg/compiler/lib/src/universe/universe.dart View 1 chunk +0 lines, -665 lines 0 comments Download
M pkg/compiler/lib/src/universe/use.dart View 1 chunk +1 line, -1 line 0 comments Download
A + pkg/compiler/lib/src/universe/world_builder.dart View 8 chunks +14 lines, -13 lines 3 comments Download
M tests/compiler/dart2js/analyze_unused_dart2js_test.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
Johnni Winther
4 years, 2 months ago (2016-09-29 09:11:41 UTC) #2
Siggi Cherem (dart-lang)
LGTM! You are definitely building a better world! https://codereview.chromium.org/2381793003/diff/1/pkg/compiler/lib/src/compiler.dart File pkg/compiler/lib/src/compiler.dart (right): https://codereview.chromium.org/2381793003/diff/1/pkg/compiler/lib/src/compiler.dart#newcode846 pkg/compiler/lib/src/compiler.dart:846: void ...
4 years, 2 months ago (2016-09-29 18:14:48 UTC) #3
Johnni Winther
Committed patchset #1 (id:1) manually as c3421b55866c99b6bf827f291bbbfb875feda10c (presubmit successful).
4 years, 2 months ago (2016-09-30 08:34:16 UTC) #5
Johnni Winther
4 years, 2 months ago (2016-09-30 08:43:15 UTC) #6
Message was sent while issue was closed. 
https://codereview.chromium.org/2381793003/diff/1/pkg/compiler/lib/src/compil...
File pkg/compiler/lib/src/compiler.dart (right):

https://codereview.chromium.org/2381793003/diff/1/pkg/compiler/lib/src/compil...
pkg/compiler/lib/src/compiler.dart:846: void processQueue(Enqueuer world,
Element main) =>
On 2016/09/29 18:14:48, Siggi Cherem (dart-lang) wrote:
> FYI: related only in the sense that we are cleaning up the world/universe
> names... While reading more about impact-strategy I noticed that we use
"world"
> in a few places like here, where we should be using "enqueuer" instead.
> 
> I'm happy to send you a CL for it, but just wanted to mention it in case you
get
> to do some renames before I do

Acknowledged.

https://codereview.chromium.org/2381793003/diff/1/pkg/compiler/lib/src/enqueu...
File pkg/compiler/lib/src/enqueue.dart (right):

https://codereview.chromium.org/2381793003/diff/1/pkg/compiler/lib/src/enqueu...
pkg/compiler/lib/src/enqueue.dart:74: WorldBuilder get universe;
On 2016/09/29 18:14:48, Siggi Cherem (dart-lang) wrote:
> might be worth renaming this field (and _universe below) at this time. But I'm
> ok doing so on a follow up CL

Acknowledged.

https://codereview.chromium.org/2381793003/diff/1/pkg/compiler/lib/src/univer...
File pkg/compiler/lib/src/universe/world_builder.dart (right):

https://codereview.chromium.org/2381793003/diff/1/pkg/compiler/lib/src/univer...
pkg/compiler/lib/src/universe/world_builder.dart:110: // TODO(sigmund): rename
to "growing/expanding/mutable world"?
On 2016/09/29 18:14:48, Siggi Cherem (dart-lang) wrote:
> remove TODO :)

Done.

Powered by Google App Engine
This is Rietveld 408576698