Rename Universe to WorldBuilder.

pkg/compiler/lib/src/compiler.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library dart2js.compiler_base;
 
 import 'dart:async' show EventSink, Future;
 
 import '../compiler_new.dart' as api;
 import 'cache_strategy.dart' show CacheStrategy;
@@ skipping 55 matching lines @@
 import 'serialization/task.dart' show SerializationTask;
 import 'ssa/nodes.dart' show HInstruction;
 import 'tokens/token.dart' show StringToken, Token, TokenPair;
 import 'tokens/token_map.dart' show TokenMap;
 import 'tracer.dart' show Tracer;
 import 'tree/tree.dart' show Node, TypeAnnotation;
 import 'typechecker.dart' show TypeCheckerTask;
 import 'types/types.dart' show GlobalTypeInferenceTask;
 import 'types/masks.dart' show CommonMasks;
 import 'universe/selector.dart' show Selector;
-import 'universe/universe.dart' show ResolutionUniverse, CodegenUniverse;
+import 'universe/world_builder.dart'
+    show ResolutionWorldBuilder, CodegenWorldBuilder;
 import 'universe/use.dart' show StaticUse;
 import 'universe/world_impact.dart' show ImpactStrategy, WorldImpact;
 import 'util/util.dart' show Link, Setlet;
 import 'world.dart' show ClosedWorld, ClosedWorldRefiner, OpenWorld, WorldImpl;
 
 typedef Backend MakeBackendFuncion(Compiler compiler);
 
 typedef CompilerDiagnosticReporter MakeReporterFunction(
     Compiler compiler, CompilerOptions options);
 
@@ skipping 239 matching lines @@
   /// Creates the resolver task.
   ///
   /// Override this to mock the resolver for testing.
   ResolverTask createResolverTask() {
     return new ResolverTask(
         resolution, backend.constantCompilerTask, openWorld, measurer);
   }
 
   // TODO(johnniwinther): Rename these appropriately when unification of worlds/
   // universes is complete.
-  ResolutionUniverse get resolverWorld => enqueuer.resolution.universe;
-  CodegenUniverse get codegenWorld => enqueuer.codegen.universe;
+  ResolutionWorldBuilder get resolverWorld => enqueuer.resolution.universe;
+  CodegenWorldBuilder get codegenWorld => enqueuer.codegen.universe;
 
   bool get analyzeAll => options.analyzeAll || compileAll;
 
   bool get compileAll => false;
 
   bool get disableTypeInference =>
       options.disableTypeInference || compilationFailed;
 
   // TODO(het): remove this from here. Either inline at all use sites or add it
   // to Reporter.
@@ skipping 487 matching lines @@
               work.element,
               () => selfTask.measureSubtask("world.applyImpact", () {
                     world.applyImpact(
                         selfTask.measureSubtask(
                             "work.run", () => work.run(this, world)),
                         forElement: work.element);
                   }));
         });
       });
 
   void processQueue(Enqueuer world, Element main) =>

[Siggi Cherem (dart-lang), 2016/09/29 18:14:48]

FYI: related only in the sense that we are cleaning up the world/universe
names... While reading more about impact-strategy I noticed that we use "world"
in a few places like here, where we should be using "enqueuer" instead.

I'm happy to send you a CL for it, but just wanted to mention it in case you get
to do some renames before I do

[Johnni Winther, 2016/09/30 08:43:14]

Acknowledged.

       selfTask.measureSubtask("Compiler.processQueue", () {
         world.nativeEnqueuer.processNativeClasses(libraryLoader.libraries);
         if (main != null && !main.isMalformed) {
           FunctionElement mainMethod = main;
           mainMethod.computeType(resolution);
           if (mainMethod.functionSignature.parameterCount != 0) {
             // The first argument could be a list of strings.
             backend.backendClasses.listImplementation
                 .ensureResolved(resolution);
             backend.registerInstantiatedType(
@@ skipping 1389 matching lines @@
   _ElementScanner(this.scanner);
   void scanLibrary(LibraryElement library) => scanner.scanLibrary(library);
   void scanUnit(CompilationUnitElement unit) => scanner.scan(unit);
 }
 
 class _EmptyEnvironment implements Environment {
   const _EmptyEnvironment();
 
   String valueOf(String key) => null;
 }