Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Issue 238043003: WebView: RegisterNativesImpl() returns bool; don't compare it for >= 0. (Closed)

Created:
6 years, 8 months ago by hans
Modified:
6 years, 8 months ago
CC:
chromium-reviews, android-webview-reviews_chromium.org
Visibility:
Public.

Description

WebView: RegisterNativesImpl() returns bool; don't compare it for >= 0. A recent version of Clang warns about this: ../../android_webview/native/java_browser_view_renderer_helper.cc:133:35: error: comparison of constant 0 with expression of type 'bool' is always true [-Werror,-Wtautological-constant-out-of-range-compare] return RegisterNativesImpl(env) >= 0; ~~~~~~~~~~~~~~~~~~~~~~~~ ^ ~ BUG=363667 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=264168

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -12 lines) Patch
M android_webview/native/aw_autofill_manager_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/native/aw_contents.cc View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/native/aw_contents_client_bridge.cc View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/native/aw_form_database.cc View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/native/aw_http_auth_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/native/aw_pdf_exporter.cc View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/native/aw_picture.cc View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/native/aw_quota_manager_bridge_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/native/aw_resource.cc View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/native/aw_settings.cc View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/native/external_video_surface_container_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/native/java_browser_view_renderer_helper.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
hans
Please take a look! (And feel free to hit the CQ box for me if ...
6 years, 8 months ago (2014-04-16 00:59:04 UTC) #1
Torne
Wow, I am shocked that gcc doesn't notice this :) LGTM.
6 years, 8 months ago (2014-04-16 07:53:25 UTC) #2
Torne
The CQ bit was checked by torne@chromium.org
6 years, 8 months ago (2014-04-16 07:53:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hans@chromium.org/238043003/1
6 years, 8 months ago (2014-04-16 07:53:46 UTC) #4
commit-bot: I haz the power
6 years, 8 months ago (2014-04-16 11:27:49 UTC) #5
Message was sent while issue was closed.
Change committed as 264168

Powered by Google App Engine
This is Rietveld 408576698