Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Side by Side Diff: android_webview/native/aw_contents_client_bridge.cc

Issue 238043003: WebView: RegisterNativesImpl() returns bool; don't compare it for >= 0. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « android_webview/native/aw_contents.cc ('k') | android_webview/native/aw_form_database.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "android_webview/native/aw_contents_client_bridge.h" 5 #include "android_webview/native/aw_contents_client_bridge.h"
6 6
7 #include "android_webview/common/devtools_instrumentation.h" 7 #include "android_webview/common/devtools_instrumentation.h"
8 #include "base/android/jni_android.h" 8 #include "base/android/jni_android.h"
9 #include "base/android/jni_array.h" 9 #include "base/android/jni_array.h"
10 #include "base/android/jni_string.h" 10 #include "base/android/jni_string.h"
(...skipping 189 matching lines...) Expand 10 before | Expand all | Expand 10 after
200 pending_js_dialog_callbacks_.Lookup(id); 200 pending_js_dialog_callbacks_.Lookup(id);
201 if (!callback) { 201 if (!callback) {
202 LOG(WARNING) << "Unexpected JS dialog cancel. " << id; 202 LOG(WARNING) << "Unexpected JS dialog cancel. " << id;
203 return; 203 return;
204 } 204 }
205 callback->Run(false, base::string16()); 205 callback->Run(false, base::string16());
206 pending_js_dialog_callbacks_.Remove(id); 206 pending_js_dialog_callbacks_.Remove(id);
207 } 207 }
208 208
209 bool RegisterAwContentsClientBridge(JNIEnv* env) { 209 bool RegisterAwContentsClientBridge(JNIEnv* env) {
210 return RegisterNativesImpl(env) >= 0; 210 return RegisterNativesImpl(env);
211 } 211 }
212 212
213 } // namespace android_webview 213 } // namespace android_webview
OLDNEW
« no previous file with comments | « android_webview/native/aw_contents.cc ('k') | android_webview/native/aw_form_database.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698