Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1134)

Side by Side Diff: android_webview/native/aw_picture.cc

Issue 238043003: WebView: RegisterNativesImpl() returns bool; don't compare it for >= 0. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "android_webview/native/aw_picture.h" 5 #include "android_webview/native/aw_picture.h"
6 6
7 #include "android_webview/native/java_browser_view_renderer_helper.h" 7 #include "android_webview/native/java_browser_view_renderer_helper.h"
8 #include "base/bind.h" 8 #include "base/bind.h"
9 #include "jni/AwPicture_jni.h" 9 #include "jni/AwPicture_jni.h"
10 #include "third_party/skia/include/core/SkPicture.h" 10 #include "third_party/skia/include/core/SkPicture.h"
(...skipping 32 matching lines...) Expand 10 before | Expand all | Expand 10 after
43 ->RenderViaAuxilaryBitmapIfNeeded( 43 ->RenderViaAuxilaryBitmapIfNeeded(
44 canvas, 44 canvas,
45 gfx::Vector2d(), 45 gfx::Vector2d(),
46 gfx::Rect(left, top, right - left, bottom - top), 46 gfx::Rect(left, top, right - left, bottom - top),
47 base::Bind(&RenderPictureToCanvas, 47 base::Bind(&RenderPictureToCanvas,
48 base::Unretained(picture_.get()))); 48 base::Unretained(picture_.get())));
49 LOG_IF(ERROR, !ok) << "Couldn't draw picture"; 49 LOG_IF(ERROR, !ok) << "Couldn't draw picture";
50 } 50 }
51 51
52 bool RegisterAwPicture(JNIEnv* env) { 52 bool RegisterAwPicture(JNIEnv* env) {
53 return RegisterNativesImpl(env) >= 0; 53 return RegisterNativesImpl(env);
54 } 54 }
55 55
56 } // namespace android_webview 56 } // namespace android_webview
OLDNEW
« no previous file with comments | « android_webview/native/aw_pdf_exporter.cc ('k') | android_webview/native/aw_quota_manager_bridge_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698