Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(310)

Side by Side Diff: android_webview/native/aw_pdf_exporter.cc

Issue 238043003: WebView: RegisterNativesImpl() returns bool; don't compare it for >= 0. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « android_webview/native/aw_http_auth_handler.cc ('k') | android_webview/native/aw_picture.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "android_webview/native/aw_pdf_exporter.h" 5 #include "android_webview/native/aw_pdf_exporter.h"
6 6
7 #include "android_webview/browser/renderer_host/print_manager.h" 7 #include "android_webview/browser/renderer_host/print_manager.h"
8 #include "base/android/jni_android.h" 8 #include "base/android/jni_android.h"
9 #include "base/logging.h" 9 #include "base/logging.h"
10 #include "content/public/browser/browser_thread.h" 10 #include "content/public/browser/browser_thread.h"
(...skipping 93 matching lines...) Expand 10 before | Expand all | Expand 10 after
104 Java_AwPdfExporter_didExportPdf(env, obj.obj(), success); 104 Java_AwPdfExporter_didExportPdf(env, obj.obj(), success);
105 } 105 }
106 106
107 bool AwPdfExporter::IsCancelled() { 107 bool AwPdfExporter::IsCancelled() {
108 // TODO(sgurun) implement. Needs connecting with the |cancel_signal| passed 108 // TODO(sgurun) implement. Needs connecting with the |cancel_signal| passed
109 // in the constructor. 109 // in the constructor.
110 return false; 110 return false;
111 } 111 }
112 112
113 bool RegisterAwPdfExporter(JNIEnv* env) { 113 bool RegisterAwPdfExporter(JNIEnv* env) {
114 return RegisterNativesImpl(env) >= 0; 114 return RegisterNativesImpl(env);
115 } 115 }
116 116
117 } // namespace android_webview 117 } // namespace android_webview
OLDNEW
« no previous file with comments | « android_webview/native/aw_http_auth_handler.cc ('k') | android_webview/native/aw_picture.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698