Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 2378893002: Fix DCHECK when track status changes in non-playing state (Closed)

Created:
4 years, 2 months ago by servolk
Modified:
4 years, 2 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix DCHECK when track status changes in non-playing state Reland of https://codereview.chromium.org/2269313002 That CL added a new unit test TrackStatusChangesWhileSuspended that turned out to be flaky. I have investigated the flakiness and tracked it down to a race condition in Renderer destruction when pipeline is being suspended. That race condition has been recently fixed (see https://codereview.chromium.org/2355173002 and crbug.com/638018) and the new test is not flaky anymore. I've confirmed that the test becomes flaky again when I revert commit bdf51ba921ccbc locally. BUG=640362 Committed: https://crrev.com/09ed890b572504e099b9e974c29c69d168881a6a Cr-Commit-Position: refs/heads/master@{#421669}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -5 lines) Patch
M media/base/pipeline_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M media/renderers/renderer_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/test/pipeline_integration_test.cc View 4 chunks +64 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
servolk
4 years, 2 months ago (2016-09-28 21:28:43 UTC) #5
DaleCurtis
lgtm
4 years, 2 months ago (2016-09-28 21:34:49 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2378893002/1
4 years, 2 months ago (2016-09-28 22:40:04 UTC) #9
chcunningham
lgtm
4 years, 2 months ago (2016-09-28 22:44:54 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-28 22:46:50 UTC) #12
commit-bot: I haz the power
4 years, 2 months ago (2016-09-28 22:48:26 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/09ed890b572504e099b9e974c29c69d168881a6a
Cr-Commit-Position: refs/heads/master@{#421669}

Powered by Google App Engine
This is Rietveld 408576698