Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 2355173002: Clear pending reads after suspend completes, not before. (Closed)

Created:
4 years, 3 months ago by DaleCurtis
Modified:
4 years, 3 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Clear pending reads after suspend completes, not before. If reads are cleared prior to suspend that does not guarantee that no further read has been started (even when playback rate == 0) since the renderers may be prerolling buffers. The abort before suspend actually does nothing but cause additional churn in some cases. Instead we should destroy the renderer and then abort any stale state. BUG=638018 Committed: https://crrev.com/c672f0c53548b3250ca5e4573f3aa6452fe6ba82 Cr-Commit-Position: refs/heads/master@{#419941}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M media/base/pipeline_impl.cc View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
DaleCurtis
4 years, 3 months ago (2016-09-21 00:23:02 UTC) #2
sandersd (OOO until July 31)
lgtm
4 years, 3 months ago (2016-09-21 00:26:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2355173002/1
4 years, 3 months ago (2016-09-21 00:27:29 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-21 01:58:34 UTC) #6
commit-bot: I haz the power
4 years, 3 months ago (2016-09-21 02:02:14 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c672f0c53548b3250ca5e4573f3aa6452fe6ba82
Cr-Commit-Position: refs/heads/master@{#419941}

Powered by Google App Engine
This is Rietveld 408576698