Fix DCHECK when track status changes in non-playing state

media/test/pipeline_integration_test.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <stddef.h>
 #include <stdint.h>
 
 #include <memory>
 #include <utility>
 
@@ skipping 903 matching lines @@
 
   Play();
 
   ASSERT_TRUE(WaitUntilOnEnded());
 
   EXPECT_HASH_EQ("f0be120a90a811506777c99a2cdf7cc1", GetVideoHash());
   EXPECT_HASH_EQ("-3.59,-2.06,-0.43,2.15,0.77,-0.95,", GetAudioHash());
   EXPECT_TRUE(demuxer_->GetTimelineOffset().is_null());
 }
 
+base::TimeDelta TimestampMs(int milliseconds) {
+  return base::TimeDelta::FromMilliseconds(milliseconds);
+}
+
 TEST_F(PipelineIntegrationTest, PlaybackWithAudioTrackDisabledThenEnabled) {
   ASSERT_EQ(PIPELINE_OK, Start("bear-320x240.webm", kHashed));
 
   // Disable audio.
   std::vector<MediaTrack::Id> empty;
   pipeline_->OnEnabledAudioTracksChanged(empty);
   base::RunLoop().RunUntilIdle();
 
   // Seek to flush the pipeline and ensure there's no prerolled audio data.
   ASSERT_TRUE(Seek(base::TimeDelta()));
 
   Play();
-  const base::TimeDelta k500ms = base::TimeDelta::FromMilliseconds(500);
+  const base::TimeDelta k500ms = TimestampMs(500);
   ASSERT_TRUE(WaitUntilCurrentTimeIsAfter(k500ms));
   Pause();
 
   // Verify that no audio has been played, since we disabled audio tracks.
   EXPECT_HASH_EQ(kNullAudioHash, GetAudioHash());
 
   // Re-enable audio.
   std::vector<MediaTrack::Id> audioTrackId;
   audioTrackId.push_back("2");
   pipeline_->OnEnabledAudioTracksChanged(audioTrackId);
@@ skipping 17 matching lines @@
   base::RunLoop().RunUntilIdle();
 
   // Seek to flush the pipeline and ensure there's no prerolled video data.
   ASSERT_TRUE(Seek(base::TimeDelta()));
 
   // Reset the video hash in case some of the prerolled video frames have been
   // hashed already.
   ResetVideoHash();
 
   Play();
-  const base::TimeDelta k500ms = base::TimeDelta::FromMilliseconds(500);
+  const base::TimeDelta k500ms = TimestampMs(500);
   ASSERT_TRUE(WaitUntilCurrentTimeIsAfter(k500ms));
   Pause();
 
   // Verify that no video has been rendered, since we disabled video tracks.
   EXPECT_HASH_EQ(kNullVideoHash, GetVideoHash());
 
   // Re-enable video.
   std::vector<MediaTrack::Id> videoTrackId;
   videoTrackId.push_back("1");
   pipeline_->OnSelectedVideoTrackChanged(videoTrackId);
   base::RunLoop().RunUntilIdle();
 
   // Seek to flush video pipeline and reset the video hash again to clear state
   // if some prerolled frames got hashed after enabling video.
   ASSERT_TRUE(Seek(base::TimeDelta()));
   ResetVideoHash();
 
   // Restart playback from 500ms position.
   ASSERT_TRUE(Seek(k500ms));
   Play();
   ASSERT_TRUE(WaitUntilOnEnded());
 
   // Verify that video has been rendered after being enabled.
   EXPECT_HASH_EQ("fd59357dfd9c144ab4fb8181b2de32c3", GetVideoHash());
 }
 
+TEST_F(PipelineIntegrationTest, TrackStatusChangesAfterPipelineEnded) {
+  ASSERT_EQ(PIPELINE_OK, Start("bear-320x240.webm", kHashed));
+  Play();
+  ASSERT_TRUE(WaitUntilOnEnded());
+  std::vector<MediaTrack::Id> track_ids;
+  // Disable audio track.
+  pipeline_->OnEnabledAudioTracksChanged(track_ids);
+  // Re-enable audio track.
+  track_ids.push_back("2");
+  pipeline_->OnEnabledAudioTracksChanged(track_ids);
+  // Disable video track.
+  track_ids.clear();
+  pipeline_->OnSelectedVideoTrackChanged(track_ids);
+  // Re-enable video track.
+  track_ids.push_back("1");
+  pipeline_->OnSelectedVideoTrackChanged(track_ids);
+}
+
+TEST_F(PipelineIntegrationTest, TrackStatusChangesWhileSuspended) {
+  ASSERT_EQ(PIPELINE_OK, Start("bear-320x240.webm", kHashed));
+  Play();
+
+  ASSERT_TRUE(Suspend());
+
+  // These get triggered every time playback is resumed.
+  EXPECT_CALL(*this, OnVideoNaturalSizeChange(gfx::Size(320, 240)))
+      .Times(AnyNumber());
+  EXPECT_CALL(*this, OnVideoOpacityChange(true)).Times(AnyNumber());
+
+  std::vector<MediaTrack::Id> track_ids;
+
+  // Disable audio track.
+  pipeline_->OnEnabledAudioTracksChanged(track_ids);
+  ASSERT_TRUE(Resume(TimestampMs(100)));
+  ASSERT_TRUE(WaitUntilCurrentTimeIsAfter(TimestampMs(200)));
+  ASSERT_TRUE(Suspend());
+
+  // Re-enable audio track.
+  track_ids.push_back("2");
+  pipeline_->OnEnabledAudioTracksChanged(track_ids);
+  ASSERT_TRUE(Resume(TimestampMs(200)));
+  ASSERT_TRUE(WaitUntilCurrentTimeIsAfter(TimestampMs(300)));
+  ASSERT_TRUE(Suspend());
+
+  // Disable video track.
+  track_ids.clear();
+  pipeline_->OnSelectedVideoTrackChanged(track_ids);
+  ASSERT_TRUE(Resume(TimestampMs(300)));
+  ASSERT_TRUE(WaitUntilCurrentTimeIsAfter(TimestampMs(400)));
+  ASSERT_TRUE(Suspend());
+
+  // Re-enable video track.
+  track_ids.push_back("1");
+  pipeline_->OnSelectedVideoTrackChanged(track_ids);
+  ASSERT_TRUE(Resume(TimestampMs(400)));
+  ASSERT_TRUE(WaitUntilOnEnded());
+}
+
 TEST_F(PipelineIntegrationTest,
        MAYBE_CLOCKLESS(BasicPlaybackOpusOggTrimmingHashed)) {
   ASSERT_EQ(PIPELINE_OK,
             Start("opus-trimming-test.webm", kHashed | kClockless));
 
   Play();
 
   ASSERT_TRUE(WaitUntilOnEnded());
   EXPECT_HASH_EQ(kOpusEndTrimmingHash_1, GetAudioHash());
 
@@ skipping 1374 matching lines @@
 
 TEST_F(PipelineIntegrationTest, BasicPlaybackPositiveStartTime) {
   ASSERT_EQ(PIPELINE_OK, Start("nonzero-start-time.webm"));
   Play();
   ASSERT_TRUE(WaitUntilOnEnded());
   ASSERT_EQ(base::TimeDelta::FromMicroseconds(396000),
             demuxer_->GetStartTime());
 }
 
 }  // namespace media