Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1266)

Unified Diff: media/base/pipeline_impl.cc

Issue 2378893002: Fix DCHECK when track status changes in non-playing state (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | media/renderers/renderer_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/base/pipeline_impl.cc
diff --git a/media/base/pipeline_impl.cc b/media/base/pipeline_impl.cc
index 7eb522b67b73106d8f09fb1da642307d4fa1fcfd..4729e2373280bd53e464e91ede177e2a32e8c6ef 100644
--- a/media/base/pipeline_impl.cc
+++ b/media/base/pipeline_impl.cc
@@ -578,7 +578,7 @@ void PipelineImpl::RendererWrapper::OnEnabledAudioTracksChanged(
}
DCHECK(demuxer_);
- DCHECK(shared_state_.renderer);
+ DCHECK(shared_state_.renderer || (state_ != kPlaying));
base::TimeDelta currTime = (state_ == kPlaying)
? shared_state_.renderer->GetMediaTime()
@@ -597,7 +597,7 @@ void PipelineImpl::RendererWrapper::OnSelectedVideoTrackChanged(
}
DCHECK(demuxer_);
- DCHECK(shared_state_.renderer);
+ DCHECK(shared_state_.renderer || (state_ != kPlaying));
base::TimeDelta currTime = (state_ == kPlaying)
? shared_state_.renderer->GetMediaTime()
« no previous file with comments | « no previous file | media/renderers/renderer_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698