Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 2378543002: (Reland) Port WebGL extension availability tests to the integration test harness. (Closed)

Created:
4 years, 2 months ago by Ken Russell (switch to Gerrit)
Modified:
4 years, 2 months ago
CC:
chromium-reviews, jam, darin-cc_chromium.org, piman+watch_chromium.org, Jamie Madill, fjhenigman
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

(Reland) Port WebGL extension availability tests to the integration test harness. These were accidentally lost during the switch to the new test harness. Convert the expectations to the new format of the test names. The old tests aren't being run anywhere any more and will be deleted. Fix longstanding mismatches in the code paths in TestExpectations. Remove support for absolute URLs. Normalize all incoming URLs. This fixes breakage of this class when adding URL prefixes. Expand unit tests. BUG=352807 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=eyaich@chromium.org,nednguyen@chromium.org,zmo@chromium.org NOTRY=true Committed: https://crrev.com/b1bfa0b098ea2ab2e191192d880c6e9dc2ae1e4a Cr-Commit-Position: refs/heads/master@{#421702}

Patch Set 1 #

Patch Set 2 : Fix bugs on Windows in support of URL prefixes. Expand unit tests. #

Patch Set 3 : Skip WebglExtension_WEBGL_compressed_texture_s3tc_srgb on Android too. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+276 lines, -64 lines) Patch
M content/test/gpu/gpu_tests/gpu_integration_test.py View 1 chunk +6 lines, -0 lines 0 comments Download
M content/test/gpu/gpu_tests/gpu_test_expectations.py View 1 chunk +3 lines, -0 lines 0 comments Download
M content/test/gpu/gpu_tests/test_expectations.py View 1 6 chunks +28 lines, -16 lines 0 comments Download
M content/test/gpu/gpu_tests/test_expectations_unittest.py View 1 5 chunks +44 lines, -11 lines 0 comments Download
M content/test/gpu/gpu_tests/webgl2_conformance_expectations.py View 1 2 2 chunks +14 lines, -6 lines 0 comments Download
M content/test/gpu/gpu_tests/webgl_conformance_expectations.py View 1 2 4 chunks +34 lines, -26 lines 0 comments Download
M content/test/gpu/gpu_tests/webgl_conformance_integration_test.py View 5 chunks +147 lines, -5 lines 0 comments Download

Messages

Total messages: 19 (11 generated)
Ken Russell (switch to Gerrit)
This is a re-land of https://codereview.chromium.org/2297673002 with a bug fix and expanded unittests for the ...
4 years, 2 months ago (2016-09-28 00:58:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2378543002/20001
4 years, 2 months ago (2016-09-28 20:45:30 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2378543002/40001
4 years, 2 months ago (2016-09-28 23:37:04 UTC) #9
commit-bot: I haz the power
Exceeded global retry quota
4 years, 2 months ago (2016-09-28 23:45:02 UTC) #11
Ken Russell (switch to Gerrit)
I'm forcing this through. The failures are infrastructure issues.
4 years, 2 months ago (2016-09-29 00:56:24 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2378543002/40001
4 years, 2 months ago (2016-09-29 00:57:00 UTC) #15
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 2 months ago (2016-09-29 01:05:01 UTC) #17
commit-bot: I haz the power
4 years, 2 months ago (2016-09-29 01:11:30 UTC) #19
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/b1bfa0b098ea2ab2e191192d880c6e9dc2ae1e4a
Cr-Commit-Position: refs/heads/master@{#421702}

Powered by Google App Engine
This is Rietveld 408576698